filter in media not working properly

Thanks again!

In your case, the problem is in your theme – Roots.

roots-master/lib/cleanup.php

line 244

function roots_request_filter($query_vars) {
  if (isset($_GET['s']) && empty($_GET['s'])) {
    $query_vars['s'] = ' ';
  }

  return $query_vars;
}
add_filter('request', 'roots_request_filter');

This filter breaks the query for Media Library with or without active EML. You can easily check it yourself by commenting this line:

//add_filter('request', 'roots_request_filter');

or changing Roots theme.

Please, contact theme author to fix it.

Nadia

Everyone, please if you have this issue:

1. Check if the date filter is working correctly, it is WP filter by default, if it’s not working properly, the problem is not EML, which uses the same native WP mechanism, but one of the plugins or themes.
2. Deactivate other plugins and change your current theme to one of WP “native” themes and check if it still be not working. In this way you can help me to find a plugin or theme that causes this issue.

If date filter is working correctly for you, and other plugins and themes do not affect the issue, then please let me know.

Thanks in advance!

Nadia

Hi Webbistro,

Awesome plugin! Overall it works and functions great, however I’m having a very similar problem as earlier posters.

With all plugins disabled, except EML, I’m able to filter by the core date menu, but not by either of the 2 taxonomies I’ve assigned to EML. Filtering within the media editor modal (when editing a post) seems to work correctly, just not on the media library page.

Let me know if you need any additional info and I’ll happily help you track this bug down.

Thanks!

Hello All,

Since no one denoted any problem during last week I am marking this issue as resolved, but feel free to let me know should you have similar issue in future.

Nadia

Hello @manifestcreative,

it seems we were typing our responses simultaneously ??

Please, check also your theme (change it to any default WP one). If the problem still persists please send me access to your project.

wordpressuxsolutions [at] gmail [dot] com

I won’t break your website in any way, no worries.

Thanks!

Nadia

Hi @webbistro,

Thanks for your speedy response. I’ll send you login credentials for the site, but it’s a bit difficult for me to test on a default theme as the media taxonomies themselves are heavily dependent on the custom theme.

I think you’ll see what I mean once you log-in.

I’m also noticing that when I click on one of my taxonomy management pages, then click the linked number of media files that are assigned to a term, it still doesn’t filter properly. Because this is a core feature I’m leaning towards it being something in my theme or the EML plugin.

It’s got me stumped tho!

Posting to an older thread but could be of use to someone. I had the same issue; it turned out to be caused by the theme which had this code in functions.php, which is intended to run on the frontend but is breaking search/filter on the backend. You see this limits results to only “posts”; since images are not posts.. no results whatsoever!

function gt_search_filter($query) {
if ($query->is_search) {
$query->set('post_type', 'post');
}
return $query;
}

I wrapped the offending line in another if statement to resolve

if (!is_admin()){ ... }