fix for ical.php

  • Resolved shawfactor

    (@shawfactor)


    2 years ago

    one line 733 there is is check that $event_cats is not empty, but if that taxonomy has been unregistered it will return and error so a better check would be:

    the-events-calendar/src/Tribe/iCal.php

    if ( ! empty( $event_cats ) && !is_wp_error($event_cats)) {
    $item[‘CATEGORIES’] = ‘CATEGORIES:’ . $this->html_decode( join( ‘,’, $event_cats ) );
    }

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Support Abz

    (@abzlevelup)

    Hi @shawfactor, thanks for sharing a fix/workaround here. I would definitely share this with the team.

    Best,
    Abz

    Plugin Support Abz

    (@abzlevelup)

    Hi @shawfactor,

    We haven’t heard from you in a while, so I’m going to mark this as resolved. Feel free to start a new thread if you have any more questions.

    Thread Starter shawfactor

    (@shawfactor)

    Team,

    Why are you resolving this, the issue is not fixed?

    Pete

    Plugin Support Abz

    (@abzlevelup)

    Hi @shawfactor, apologies, thought that it was related to the latest fix we released for the iCal issue. This is unrelated to that, and we’d be opening back this thread.

    I already reached out to one of our devs and I’d get back to you with more details whenever I hear from them.

    Appreciate your patience here.

    Best,
    Abz

    Plugin Support Abz

    (@abzlevelup)

    Hi @shawfactor, I appreciate your patience here. We already created an internal bug ticket for this, and I added your case. Thanks for all the details. I will definitely pass it along to our devs.

    The bug ticket is now In Progress. However, I am unable to provide an exact date or time estimate for when this bug will be fixed, but you’ll be notified when there are any updates.

    If you do have other concerns or issues you need help with, please create another ticket, as it helps us track different issues.

    Again, thank you for your patience. Hang in there.

    Best,
    Abz

    —
    Internal Bug Ticket Reference:
    TEC-4619

    Plugin Support Guga Alves

    (@gugaalves)

    Hi @shawfactor,
    ?
    We’re back with good news!
    ?
    Our developers have just released the Events Calendar version 6.0.7,?which addresses the bug ticket related to your bug here (among other items).

    Please update your Events Calendar plugin to include those improvements over your website.

    Best regards

    Thread Starter shawfactor

    (@shawfactor)

    Th is is still not fixed, your developers are sloppy

    By making $event_cats an array the !is_wp_error( $event_cats ) check no longer works, you needs to convert to array after checking whether an error was returned

    Plugin Support Abz

    (@abzlevelup)

    Hi @shawfactor,

    Sorry to hear about this, and thanks for confirming that this has not been fixed on your end. I already shared this information with our devs. I’d get back to you again whenever I hear from them.

    Appreciate your patience here.

    Plugin Support Darian

    (@d0153)

    Hi @shawfactor

    Hope you are well. Are you still having the issue with the latest version of our plugin?

    Looking forward to your reply.

    Plugin Support Darian

    (@d0153)

    Hi @shawfactor

    This thread has been inactive for a while, so we’ll go ahead and mark it Resolved. Please open a new thread if any other questions arise, and we’d be happy to help.

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘fix for ical.php’ is closed to new replies.