• Could you fix the wrong text domain used in include/registration-functions.php ?
    This could simply be done by finding ‘leaky_paywall’ (including apostrophes) and replacing it with ‘leaky-paywall’ (essentially the underscore needs to become a dash)

    Thanks!

    update: maybe you could directly fix some static translations inside <ul class=”leaky-paywall-subscription-details”> at shortcodes.php? like ‘Forever’ (line 635), ‘Yes’ and ‘No’ (line 636), etc.. ?

    • This topic was modified 6 years, 4 months ago by remi123.
    • This topic was modified 6 years, 4 months ago by remi123. Reason: static translations inside shortcodes.php
Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Contributor Jeremy Green

    (@endocreative)

    Thanks for the heads up on these. They will be updated in the next Leaky Paywall release.

    Thread Starter remi123

    (@remi123)

    I also noticed line 594 (shortcodes.php) is static;
    $content = '<p>Please <a href="' . get_page_link( $settings['page_for_subscription'] ) . '">go to the subscribe page</a> to choose a subscription level.</p>';

    I assume there could be a lot more of these static lines or words.
    Are you going to fix all of these to be translatable in your plugin? That would be great to be looking forward to.

    Thread Starter remi123

    (@remi123)

    @endocreative do you have an estimation when the next update will be released?

    • This reply was modified 6 years, 4 months ago by remi123. Reason: tagged wrong user
    Plugin Contributor Jeremy Green

    (@endocreative)

    We have just released version 4.10.13 with those strings updated to be translatable.

    Thread Starter remi123

    (@remi123)

    Thanks! Looks good, still found one two tho.

    Could you change line 3015 in functions.php from:
    $display_price = 'Free';
    to:
    $display_price = __( 'Free', 'leaky-paywall' );

    and line 649 in shortcodes.php from:
    $content_access_description .= ucfirst( $type['allowed'] ) . ' ' . $type['post_type'] . 's';
    to:
    $content_access_description .= __( 'Unlimited', 'leaky-paywall' ) . ' ' . $type['post_type'] . 's';

    The last part of the line above is still English in my Dutch website, it seems it cannot be translated although the default WordPress translation has the words ‘posts’, ‘pages’ etc.. i made a workaround by replacing the word ‘posts’ in Dutch by using the ‘leaky_paywall_content_access_description’-filter. Maybe you can find a translation fix for this later on?

    • This reply was modified 6 years, 4 months ago by remi123. Reason: found a second one
    • This reply was modified 6 years, 4 months ago by remi123. Reason: type
    Thread Starter remi123

    (@remi123)

    another two;

    line 305 in shortcodes.php from:
    $profile_table .= ' <td>' . ucfirst( $status ) . '</td>';
    to:
    $profile_table .= ' <td>' . __( ucfirst( $status ), 'leaky-paywall' ) . '</td>';

    line 307 from:
    $profile_table .= ' <td>' . $profile_payment . '</td>';
    to:
    $profile_table .= ' <td>' . __( $profile_payment, 'leaky-paywall' ) . '</td>';

    Thread Starter remi123

    (@remi123)

    and also line 560 please:

    from:
    $results .= '<p><button type="submit" onclick="return confirm(\'Deleting your account will delete your access and all your information on this site. If you have a recurring subscription, you must cancel that first to stop payments. Are you sure you want to continue?\')">Delete Account</button></p>';
    to:

    $results .= sprintf(
    	'<p><button type="submit" onclick="return confirm(\'%1$s\')">%2$s</button></p>',
    	esc_attr__( 'Deleting your account will delete your access and all your information on this site. If you have a recurring subscription, you must cancel that first to stop payments. Are you sure you want to continue?', 'leaky-paywall' ),
    	__( 'Delete Account', 'leaky-paywall' )
    );
    Thread Starter remi123

    (@remi123)

    Yeah.. there are actually too much words and lines hardcoded English..

    For now I’ve modified several files of your plugin but do you think your plugin becomes 100% translation ready in near the future?

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Fix wrong text domain used in registration-functions.php’ is closed to new replies.