Fixed some bug…

  • Resolved Anonymous User 357386

    (@anonymized-357386)


    8 years, 4 months ago

    https://pastebin.com/53sJD4MF

    (more error in source view – firefox – cause bad code formatting, now fixed).

    here with search bar also for guest: https://pastebin.com/0GH1dYKU
    also, i’ve change offset on-click (by js) to 60px (caus bad view if adminbar is active)…

    maybe some little settings for this (search bar and offset) can be a good idea!

    ah, what is the little arrow left to print button?

    line 3088… click on this button and nothing happen ??

    echo "<a class='quotes-llama-quote-author-back quotes-llama-inline' title='" . esc_html__( 'Return to' ) . ' ' . $this->strip_trim_wp_kses_post( $author ) . "' href='#" . $author . "'><input type='button' value='&larr;'></a>";
echo "<input type='button' value='Print' class='quotes-llama-print')"; ?>

    and, see now, also an error in line 3088:
    echo "<input type='button' value='Print' class='quotes-llama-print')"; ?>
    instead of:
    echo "<input type='button' value='Print' class='quotes-llama-print'>"; ?>

    • This topic was modified 8 years, 4 months ago by Anonymous User 357386.
    • This topic was modified 8 years, 4 months ago by Anonymous User 357386.
Viewing 11 replies - 16 through 26 (of 26 total)
  • Plugin Author oooorgle

    (@oooorgle)

    Seems for starters I have a bad path for the languages. Another user had stated it was working for him so I assumed it was correct. I changed line 11 to be Domain Path: /lang

    Now I just need to figure out why only some translations are working and not others like the top-most link.

    Also, until I get yet another update out it seems adding or editing quotes doesn’t work as it isn’t able to translate before processing $_REQUESTS ( which I foolishly tied to the buttons text ) so I have that fixed in the next update, FYI.

    Thread Starter Anonymous User 357386

    (@anonymized-357386)

    ok, good work ??
    if u can, try to fix also $quote->img_url to fetch directly thumbnail size!
    atm this fetch original size and resize via css to 100×100.
    thewn i’ve an image of 1024×1024 in my quote, and resized to 100×100, but in pageload/pagespeed this remain an image size of 1024×1024 (and if we have a page with more quotes and more images… we can obtain a great improvement if load directly thumbnail image) ??

    regards,
    S.N. ??

    Thread Starter Anonymous User 357386

    (@anonymized-357386)

    ever for optimize pageload and code, i request another little fix:

    if is possible to separate css for widget and for page!
    widget require just some little code.
    entire css contain a lot of code unuseful for widget.

    then, usually, we load a lot of unuseful css code (eg: when we run homepage with widget).

    regards,
    S.N.

    Plugin Author oooorgle

    (@oooorgle)

    Yes! Separating the css sounds like a great idea and you are correct it will provide a better page load. I was about to update again with some fixes to the encoding so I probably can work this into it.

    Still working on the thumbnail images too.

    Thanks!

    Plugin Author oooorgle

    (@oooorgle)

    Separating the css is done.

    quotes-llama-style.css
    split into:
    quotes-llama.css (dash-icons and readmore link styling loaded on front-end)
    quotes-llama-widget.css (widget styling and styling for [quote-llama], [quote-llama id=''] shortcodes)
    quotes-llama-page.css (page styling [quote-llama mode='page'])
    quotes-llama-gallery.css (gallery styling [quote-llama mode='gallery'])

    Seems to be a very nice improvement, you are awesome!

    Plugin Author oooorgle

    (@oooorgle)

    ?? Library now pulls the thumbnail URL instead of the full image.

    Thread Starter Anonymous User 357386

    (@anonymized-357386)

    so good! thank’u ??

    Thread Starter Anonymous User 357386

    (@anonymized-357386)

    hi!
    i test just now new release, but i need to inform that image remain as full size (nothing seems to be changed).
    u can test, if u glad, here: https://www.laltroweb.it/citazioni/#Anonimo

    Thread Starter Anonymous User 357386

    (@anonymized-357386)

    edit: sorry! ok, i seen now i need to save again all quotes ??
    ill try to append -150×150.ext via database, is best ??

    Thread Starter Anonymous User 357386

    (@anonymized-357386)

    download/export *_quotes_llama table from database;
    notepad++ search and replace with regex;

    search: .(gif|jpg|png|bmp)’\)
    replace: -150×150.$1’\)

    delete old table, then, import!
    just two minutes and all is done ??

    Plugin Author oooorgle

    (@oooorgle)

    That’s great I am glad to hear it’s working for you and others too. Trying to figure out a way to provide direct links to quotes and authors too, not sure of when but it’s on the to-do list.

Viewing 11 replies - 16 through 26 (of 26 total)
  • The topic ‘Fixed some bug…’ is closed to new replies.