• Resolved yortem

    (@yortem)


    Hi, i have few sites that use your plguins.
    the version that was installed in them was 1.8.1, after I updated to 1.8.6 i’ve noticed few bugs.

    1. The font of the admin panel is now Tahoma, not Arial as it was before.
    2. My panel was in Hebrew but now if i go in to settings the default language is English (United States).

    I’m sure it’s something to do with your plugin because i tried it in few sites

Viewing 11 replies - 1 through 11 (of 11 total)
  • Got an issue with the language in the back-office as well.
    Nothing’s translated since this update, I just see crappy translation keys…

    Thank you for the report. I submitted a patch to fix this issue here [1] and I am waiting for my co-workers to review the changes and to test the code. When I have approval I will release a new version of the plugin including the fix. Notice that this only fixes the issue with the default language, the other problem that you mentioned about the font being Tahoma instead of Arial, I cannot fix that because the plugin has nothing to do with the fonts of the website.

    [1] https://github.com/Sucuri/sucuri-wordpress-plugin/pull/38/commits/765792c

    I just updated the plugin from 1.8.3 to 1.8.6 and I can confirm there seems to be an issue with the WordPress Site Language setting.

    I had it set to a non English (United States) language but after updating your plugin it seems to be set and stuck to English (United States). Trying to change the Site Language setting fails. Strange thing is that the Dashboard language is actually still displayed in the non English (United States) language …

    Deactivating the plugin immediately restores the correct display and functioning of the Site Language setting in the General Settings page …

    Really think this needs your immediate attention ??

    Oh by the way I’m on WordPress 4.7.5, PHP 7.0.3, Apache 2.4.18, MySQL 5.7.13

    error_log shows some of these (probably unrelated and PHP 7 specific):

    Deprecated: Non-static method SucuriScanSiteCheck::ajaxMalwareScan() should not be called statically in C:\\trumpisanidiot\\wp-content\\plugins\\sucuri-scanner\\src\\pagehandler.php on line 187, referer: https://www.trumpisanidiot.com/wp-admin/admin.php?page=sucuriscan

    Every class method is defined as static in the SucuriScanSiteCheck class except the last method: ajaxMalwareScan() …

    @yorman
    Looks like our posts crossed one another. Just noticed your post (4 minutes earlier than mine). Anyway happy to hear the Site Language issue is being dealt with.
    So now only expecting a short reacting on the Non-static method issue … ??

    • This reply was modified 7 years, 8 months ago by pronl.

    Thank you, I fixed the non-static method call here [1] I will talk with the development team to see if they can accelerate the review of my changes so the next version of the plugin is released fast. If you want, you can also install the development version of the code from here [2] but be aware that this is a beta repository and is not intended for production, but in this case it will help you mitigate the issues that you are experiencing.

    [1] https://github.com/Sucuri/sucuri-wordpress-plugin/pull/38/commits/4c51445
    [2] https://github.com/cixtor/sucuri-wordpress-plugin/archive/master.zip

    I’m having the same problem. Deactivating the plugin for now…

    I’m having the same problem. With older version i havent problems. Development version doesn’t fix it ??

    Same issue here.
    my site turned to English( emails and etc…)
    Please fix as Soon as you can please…

    Hello everyone. Thank you for your patience.

    We just released version 1.8.7 which includes, among many changes, one that targets the issues that you are all experiencing in your websites. Please update and let me know how it works for you. The problem with the language being reverted back to English was caused by an override of the global $locale variable, which works well for the core pages, but seems to affect some 3rd-party plugins.

    We fixed this by detecting if the language of the website is supported by the plugin, otherwise the plugin will copy the English POT file into a new file that will be loaded by the non-English site, you will still see the plugin in English (until we translate it to your language) but the rest of the interface and 3rd-party plugins will still load the same language that you have configured in the settings page.

    Thread Starter yortem

    (@yortem)

    both of my problems are solved. i didn’t notice anything else yet. thanks.

    @yorman

    Thank you for your excellent support.
    No one ever says so on these forums but I think you are doing a great job !

    … was caused by an override of the global $locale variable, which works well for the core pages, but seems to affect some 3rd-party plugins.

    So your plugin is no longer overriding the global $locale variable ?

    It’s not that some 3rd-party plugins are doing something wrong with language ?

    @pronl — thank you for your kind words.

    The plugin is no longer overriding the global $locale variable. If the website is set to French, for example, the plugin will check if this file exists [1] if the file exists it will use that translation. If the file does not exists, it will copy the English file from here [2] to that other path so the website and other plugins will keep loading the French translation but the Sucuri plugin will load the English translation, at least until we offer an official translation to French or any other language.

    However, notice in the patch [3] that the plugin expects to have write permissions in the languages directory in order to copy the English file, if the plugin has no permission to execute this operation it will do what it was doing before, which is to override the $locale variable, otherwise the interface will display only the placeholders for the text. This is the only good way to do this since the translations are too dense to embed them into the PHP files, which is what other plugins do.

    If anyone else is having the same issue please make sure that this directory [4] is writable by the PHP interpreter. Alternatively, you can simply copy and paste (using FTP) this file [2] into a new one with the name of the locale that your website is using.

    [1] /wp-content/plugins/sucuri-scanner/languages/sucuri-scanner-fr_FR.po
    [2] /wp-content/plugins/sucuri-scanner/languages/sucuri-scanner-en_EN.po
    [3] https://github.com/Sucuri/sucuri-wordpress-plugin/commit/765792c
    [4] /wp-content/plugins/sucuri-scanner/languages/

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘Font and Language changed after update’ is closed to new replies.