font-family: “post-snippets” !important; conflict

  • Resolved mpmchugh

    (@mpmchugh)


    3 years, 7 months ago

    This line in Post-Snippet’s CSS is way too broad and conflicts with other plugins like the Divi Builder plugins interface, as it overrides its icons. 

    [data-icon]:before {
  font-family: "post-snippets" !important;
}

    Please get rid of the !important declaration, and/or make your css more specific to the Post Snippets plugin, so it does not conflict.

    https://www.dropbox.com/s/ijqth84qxcsdeio/post-snippet-font.png?dl=0

    • This topic was modified 3 years, 7 months ago by mpmchugh.
    • This topic was modified 3 years, 7 months ago by mpmchugh.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter mpmchugh

    (@mpmchugh)

    Just prefixing a “.post-snippets ” to the offending selectors seems to work…

    .post-snippets [data-icon]:before {
  font-family: "post-snippets" !important;
  font-style: normal !important;
  font-weight: normal !important;
  font-variant: normal !important;
  text-transform: none !important;
  speak: none;
  line-height: 1;
  -webkit-font-smoothing: antialiased;
  -moz-osx-font-smoothing: grayscale;
}

.post-snippets [class^="wp-ps-"]:before,
.post-snippets [class*=" wp-ps-"]:before {
  font-family: "post-snippets" !important;
  font-style: normal !important;
  font-weight: normal !important;
  font-variant: normal !important;
  text-transform: none !important;
  speak: none;
  line-height: 1;
  -webkit-font-smoothing: antialiased;
  -moz-osx-font-smoothing: grayscale;
}
    • This reply was modified 3 years, 7 months ago by mpmchugh.
    • This reply was modified 3 years, 7 months ago by mpmchugh.

    Hi @mpmchugh,

    Thank you for contacting us. We have forwarded the changes to our technical team. Once they approve them, we will release the changes in our upcoming update.

    Hi @mpmchugh,

    Thanks for your patience, Can you share the steps to reproduce the CSS issue because we are unable to replicate the issue on our end.

    It would be great if you share screenshots or screencast video.

    Thanks

    Hi @mpmchugh,

    Due to a lack of activity, we are going to mark this thread as resolved. If you have any other issues, please feel free to open a new thread.

    Have a great day!

    Thanks

    Thread Starter mpmchugh

    (@mpmchugh)

    Sorry, this fell off my radar until after installing a new update of yours.

    The steps to reproduce are just having the Divi Builder Plugin installed along with Post Snippets. Did you install the Divi Builder to test with your Post Snippets plugin?

    The !important declaration in your css as noted above breaks the Divi Builder’s own icon loading. Just being more specific in your css, by prefixing them with .post-snippets fixes the issue, as I described.

    I keep having to re-apply the fix with your updates.

    As this is an admin only issue, not sure why your adding the prefix would be an issue. It might also you to even remove the !important, which should rarely be needed, and never used so broadly as you are doing. Having your CSS more specific is always a good thing in cases like this.

    • This reply was modified 3 years, 1 month ago by mpmchugh.
    • This reply was modified 3 years, 1 month ago by mpmchugh.
    A.Tariq

    (@arsalantariq)

    Hi @mpmchugh,

    Thanks for pointing this out, We have forwarded the issue to our technical team, and we will fix this in our upcoming release.

    Thanks

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘font-family: “post-snippets” !important; conflict’ is closed to new replies.