Footnotes use in Popup Maker

@squatcher

Thank you for reporting this bug. It is fixed in current v2.5.1 released just before answering so you get a full response with the solution. But in the popups, the tooltips don’t show up and scrolling does not work; only the reference container does expand when a referrer (or the button) is clicked. I noticed that for the popup, Footnotes does not grab the settings from the DB, so it outputs the footnotes markup as if tooltips were disabled in the popup. In the reference container in the popup, the scroll script has the default scroll offset value instead of the value set in the dashboard, and does not work. At least the footnotes are now processed, but…

Was this ever intended to be usable there?

No, never. Early attempts to enlarge support to some other parts mostly failed, and supporting footnotes in popups was not envisaged yet.

Only since Pea (@misfist) established the principle, two weeks ago, that not supporting footnotes wherever they are used is wrong, and provided alongside the name of the hook used for the added content on category pages, things have started to improve but are still far from ideal.

Popup Maker from Code?Atlantic—widest used—calls the popup content hook ‘pum_popup_content’. A filter for this one has been added for now; we need to look into many other plugins to support all hooks where footnotes may be used in, but already for Popup?Maker?WP I’m quite unable to find the hook name. If you are using this one, I’ll create an account to test it through.

Thanks for helping improve the plugin.

• This reply was modified 3 years, 10 months ago by pewgeuges.

@squatcher

12 days ago I wrote:

But in the popups, the tooltips don’t show up and scrolling does not work; only the reference container does expand when a referrer (or the button) is clicked. I noticed that for the popup, Footnotes does not grab the settings from the DB, so it outputs the footnotes markup as if tooltips were disabled in the popup. In the reference container in the popup, the scroll script has the default scroll offset value instead of the value set in the dashboard, and does not work. At least the footnotes are now processed, but…

The tooltips are now fixed; the bug was due to the coding error of relying on properties used in one method before they were loaded in another method due to diverging priority levels. The fix is in the code and will be released with upcoming v2.5.4. Sorry please for the delay.

As of scrolling, it keeps not working despite the correct offset is now loaded and stands in the reference container inline script. I suspect that it is in the nature of popups not to scroll, unless they happen to be so tall the visitor needs to scroll manually e.g. to read the last footnote in the reference container, if not reading it in the tooltip.

The presence of the footnote button in the editor, that made you wonder, is due to the fact that Popup?Maker uses the classic editor.

Thank you again for the topic! The fix improves the Footnotes plugin’s usability.