Free account registration seems broken

  • Resolved 1clickmedia

    (@1clickmedia)


    1 year, 8 months ago

    Version 2.11 works, just updated to 2.11.1. Before the update registration works fine. After the update my free account level doesn’t work. Users can no longer hit the Submit and Confirm button. The form seems to be looking for fields that are only present when the financial information is required. With free account they aren’t on the page.

    Here are the errors I’m seeing in the Console:

    [Error] An invalid form control with name=’bfirstname’ is not focusable.
    [Error] An invalid form control with name=’blastname’ is not focusable.
    [Error] An invalid form control with name=’baddress1′ is not focusable.
    [Error] An invalid form control with name=’bcity’ is not focusable.
    [Error] An invalid form control with name=’bzipcode’ is not focusable.
    [Error] An invalid form control with name=’bphone’ is not focusable.

    I’ve reverted to v2.11 for now.

    • This topic was modified 1 year, 8 months ago by 1clickmedia.

    The page I need help with: [log in to see the link]

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Jason Coleman

    (@strangerstudios)

    Thanks for the heads up on this. We are looking into it.

    This sounds like it may be related to this change from 2.11.1 (https://github.com/strangerstudios/paid-memberships-pro/pull/2511) which adds the “required” field attribute to required fields at checkout. This is a good idea for accessibility and other reasons, but perhaps some of those fields with the required attribute are hidden (this is normal when using discount codes or multiple gateways; even free levels might have billing fields rendered and hidden on the page because a discount code might change it to be paid – an odd edge case) and being required by your browser to submit the form.

    FYI I tested checkout on that page, but then realized you had reverted to 2.11, so I wouldn’t see the issue anyway. :/

    I am having some trouble reproducing this. I think it may be browser dependent. Let me know what OS and browser you were testing in.

    Thread Starter 1clickmedia

    (@1clickmedia)

    I’ve reverted the reversion ?? You can test it now and see that registration is broken on that page. Let me know after you test so I can undo the undo and get registration working again.

    I’m on a Mac. I tried in Safari and Firebox. The specific errors I posted are from Safari. With Firefox nothing goes into the console and the Submit button just does nothing with no reported errors.

    • This reply was modified 1 year, 8 months ago by 1clickmedia.
    • This reply was modified 1 year, 8 months ago by 1clickmedia.
    Plugin Author Jason Coleman

    (@strangerstudios)

    Thanks. I see the error on your page. You can revert back to 2.11. I need to recreate it on my own dev sites so I can continue to test revisions.

    I am *sometimes* getting the error, which is alarming. I might just revert this change if the attribute is inconsistent like this. Every fix I think of feels a bit hacky and likely to have edge cases for folks using certain add ons and customizations.

    Thread Starter 1clickmedia

    (@1clickmedia)

    Yup, I’ve got a few add-ons and custom plugins, so I may be one of those edge cases. I’ve reverted for now, but also happy to branch off a staging environment if that’s helpful.

    Plugin Author Jason Coleman

    (@strangerstudios)

    Hi there. I’ve decided to revert the change. We will keep looking into this.

    Version 2.11.2 of PMPro is out now. You can upgrade to that version now to get the other enhancements and fixes in 2.11.1 without that new code that broke things.

    The code in question here is in a JS file, which is sometimes cached by performance plugins. So be sure to also refresh your caches.

    Let me know if things are working again for you or if you are still having issues.

    We will go back to the drawing board RE how to get the benefits of the required attribute without breaking things for some browsers.

    Thread Starter 1clickmedia

    (@1clickmedia)

    Done and done. Thanks!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Free account registration seems broken’ is closed to new replies.