FTP setting can&#8217;t be saved

(@badarmor)

Hi.

I think it’s some cache issue.

I did more logging.
I inserted after update_site_option( ‘boldgrid_backup_settings’, $settings );
next code
$settings1 = get_site_option( ‘boldgrid_backup_settings’);
and then save serialize($settings1) to file and as result there were data I actualy did input.

After that i went to phpmyadmin and found this record ‘boldgrid_backup_settings’ in the option table and there were wrong corrupted data. In the retention_count field was strange string. Have no idea why.

It’s pretty weird to me.

Regards,
Vyacheslav

This reply was modified 4 years, 10 months ago by Vyacheslav.
This reply was modified 4 years, 10 months ago by Vyacheslav.

Thread Starter

(@badarmor)

Oh sorry it seems data is encoded some how. It’s not corruted. It’s done to protect users data. I see.

Plugin Author

(@bwmarkle)

Hi @badarmor, thanks for continuing to look into this! I was able to watch the second video you supplied. I’ll get back to you shortly, I’m looking into this now.

Plugin Author

(@bwmarkle)

Hi @badarmor

I think if we hook into the pre_update_option_{$option} filter, we can track down exactly where in the code the retention settings are being changed from.

I created a video to show you what I’m referring to – https://youtu.be/cUeV3S7NGcU – I’ll include below the info however just in case you don’t want to watch the video.

FOR ANYONE READING THIS, INCLUDING @badarmor MAKING A MISTAKE EDITING ANY OF THE FILES BELOW CAN BREAK YOUR WordPress SITE. IF YOU DO NOT FEEL COMFORTABLE MAKING THESE CHANGES, PLEASE DO NOT.

First, edit your wp-config.php file and specify an error log file, such as:
ini_set( "error_log", "/home/user/error_log.txt" );

Then, edit the main boldgrid-backup.php file and add the following code:

If you update the main plugin file with this code:
/*
 * Log to our error log when Total Upkeep settings are updated.
 *
 * @param mixed  $value     The new, unserialized option value.
 * @param mixed  $old_value The old option value.
 * @param string $option    Option name.
 */
add_filter( 'pre_update_option_boldgrid_backup_settings', function( $value, $old_value, $option ) {
	$e = new \Exception();
	$e = explode( "\n", $e->getTraceAsString() );

	error_log( print_r( array(
		'Message:'                    => 'Total Upkeep settings have been updated.',
		'Old value for ftp retention:' => empty( $old_value['remote']['ftp']['retention_count'] ) ? 'empty' : $old_value['remote']['ftp']['retention_count'],
		'New value for ftp retention:' => empty( $value['remote']['ftp']['retention_count'] ) ? 'empty' : $value['remote']['ftp']['retention_count'],
		'Trace:'                       => $e,
	),1));

	return $value;
}, 10, 3 );

After the settings change, you should see something like the following in your error log:

[30-Apr-2020 17:24:49 UTC] Array
(
    [Message:] => Total Upkeep settings have been updated.
    [Old value for ftp retention:] => 6
    [New value for ftp retention:] => 5
    [Trace:] => Array
        (
            [0] => #0 /home/bradm/public_html/wp-includes/class-wp-hook.php(287): {closure}(Array, Array, 'boldgrid_backup...')
            [1] => #1 /home/bradm/public_html/wp-includes/plugin.php(206): WP_Hook->apply_filters(Array, Array)
            [2] => #2 /home/bradm/public_html/wp-includes/option.php(333): apply_filters('pre_update_opti...', Array, Array, 'boldgrid_backup...')
            [3] => #3 /home/bradm/public_html/wp-includes/option.php(1630): update_option('boldgrid_backup...', Array, 'no')
            [4] => #4 /home/bradm/public_html/wp-includes/option.php(1204): update_network_option(1, 'boldgrid_backup...', Array)
            [5] => #5 /home/bradm/public_html/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-ftp-page.php(231): update_site_option('boldgrid_backup...', Array)
            [6] => #6 /home/bradm/public_html/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-ftp-page.php(126): Boldgrid_Backup_Admin_Ftp_Page->settings_save()
            [7] => #7 /home/bradm/public_html/wp-includes/class-wp-hook.php(287): Boldgrid_Backup_Admin_Ftp_Page->settings('')
            [8] => #8 /home/bradm/public_html/wp-includes/class-wp-hook.php(311): WP_Hook->apply_filters('', Array)
            [9] => #9 /home/bradm/public_html/wp-includes/plugin.php(478): WP_Hook->do_action(Array)
            [10] => #10 /home/bradm/public_html/wp-admin/admin.php(254): do_action('admin_page_bold...')
            [11] => #11 {main}
        )

)

If you can share with us the info from the log when the retention settings are being changed, it should help us resolve this issue.

Thanks!
– Brad

Thread Starter

(@badarmor)

Hi Brad.

I did it as you ask.
Here is the log

[30-Apr-2020 18:08:33 UTC] Array
(
[Message:] => Total Upkeep settings have been updated.
[Old value for ftp retention:] => 3
[New value for ftp retention:] => 2
[Trace:] => Array
(
[0] => #0 the_path_to_site/wp-includes/class-wp-hook.php(287): {closure}(Array, Array, ‘boldgrid_backup…’)
[1] => #1 the_path_to_site/wp-includes/plugin.php(206): WP_Hook->apply_filters(Array, Array)
[2] => #2 the_path_to_site/wp-includes/option.php(333): apply_filters(‘pre_update_opti…’, Array, Array, ‘boldgrid_backup…’)
[3] => #3 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-ftp-page.php(252): update_option(‘boldgrid_backup…’, Array)
[4] => #4 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-ftp-page.php(131): Boldgrid_Backup_Admin_Ftp_Page->settings_save()
[5] => #5 the_path_to_site/wp-includes/class-wp-hook.php(287): Boldgrid_Backup_Admin_Ftp_Page->settings(”)
[6] => #6 the_path_to_site/wp-includes/class-wp-hook.php(311): WP_Hook->apply_filters(”, Array)
[7] => #7 the_path_to_site/wp-includes/plugin.php(478): WP_Hook->do_action(Array)
[8] => #8 the_path_to_site/wp-admin/admin.php(254): do_action(‘admin_page_bold…’)
[9] => #9 {main}
)

)

[30-Apr-2020 18:08:36 UTC] Array
(
[Message:] => Total Upkeep settings have been updated.
[Old value for ftp retention:] => 3
[New value for ftp retention:] => 3
[Trace:] => Array
(
[0] => #0 the_path_to_site/wp-includes/class-wp-hook.php(287): {closure}(Array, Array, ‘boldgrid_backup…’)
[1] => #1 the_path_to_site/wp-includes/plugin.php(206): WP_Hook->apply_filters(Array, Array)
[2] => #2 the_path_to_site/wp-includes/option.php(333): apply_filters(‘pre_update_opti…’, Array, Array, ‘boldgrid_backup…’)
[3] => #3 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-remote-settings.php(224): update_option(‘boldgrid_backup…’, Array)
[4] => #4 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-remote-settings.php(209): Boldgrid_Backup_Admin_Remote_Settings->save_settings(Array)
[5] => #5 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-remote-settings.php(233): Boldgrid_Backup_Admin_Remote_Settings->save_setting(‘last_login’, 1588270116)
[6] => #6 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-ftp.php(999): Boldgrid_Backup_Admin_Remote_Settings->set_last_login()
[7] => #7 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-ftp.php(841): Boldgrid_Backup_Admin_Ftp->log_in()
[8] => #8 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-ftp.php(736): Boldgrid_Backup_Admin_Ftp->is_setup(false)
[9] => #9 the_path_to_site/wp-content/plugins/boldgrid-backup/admin/remote/class-boldgrid-backup-admin-ftp-hooks.php(117): Boldgrid_Backup_Admin_Ftp->get_details()
[10] => #10 the_path_to_site/wp-includes/class-wp-hook.php(287): Boldgrid_Backup_Admin_Ftp_Hooks->is_setup_ajax(”)
[11] => #11 the_path_to_site/wp-includes/class-wp-hook.php(311): WP_Hook->apply_filters(”, Array)
[12] => #12 the_path_to_site/wp-includes/plugin.php(478): WP_Hook->do_action(Array)
[13] => #13 the_path_to_site/wp-admin/admin-ajax.php(175): do_action(‘wp_ajax_boldgri…’)
[14] => #14 {main}
)

)

This reply was modified 4 years, 10 months ago by Vyacheslav.
This reply was modified 4 years, 10 months ago by Vyacheslav.

Plugin Author

(@bwmarkle)

Hi @badarmor,

One of your traces say:

class-boldgrid-backup-admin-ftp-page.php(252)

… but that file does not have a line 252 (if you look here). Does that file contain code that you’ve added for testing?

—

To confirm, you changed the retention from 3 to 2, and then it got saved again as 3? That’s what it looks like from the info you provided.

It says at 18:08:33 it saved the retention to 2, but 3 seconds later at 18:08:36 it shows the retention setting at 3 again.

I think it’s some cache issue.

What kind of caching system are you using? Are you able to temporarily disable the caching and test again to see if this problem still occurs?

Thread Starter

(@badarmor)

Hi Brad.

… but that file does not have a line 252 (if you look here). Does that file contain code that you’ve added for testing?

Yes.

To confirm, you changed the retention from 3 to 2, and then it got saved again as 3? That’s what it looks like from the info you provided.

It says at 18:08:33 it saved the retention to 2, but 3 seconds later at 18:08:36 it shows the retention setting at 3 again.

Yes.

What kind of caching system are you using? Are you able to temporarily disable the caching and test again to see if this problem still occurs?

I use w3tc. Don’t know why but I sure you know it ??
All caches are enabled.

And I remade error log without my code added. This is the same situation want to change retention from 3 t o2

Thread Starter

(@badarmor)

I think tommorow in the morning when traffic is low I could disable the caching.
Or may be you suggest disable only separate caching?

Thread Starter

(@badarmor)

And I’m sorry I forgot to delete previous content from the file. What you need starts from [30-Apr-2020 18:46:21 UTC]

Plugin Author

(@bwmarkle)

Hi @badarmor,

I think tommorow in the morning when traffic is low I could disable the caching.
Or may be you suggest disable only separate caching?

I installed W3 Total Cache and tried replicating the issue, but I couldn’t. I don’t think it’s a caching issue… It could be, but I couldn’t replicate.

—

I’m a little puzzled at this point.

I guess the next thing I would check is that when we’re saving the retention from 3 to 2, that it saves successfully.

If you edit the bottom of this file, class-boldgrid-backup-admin-ftp-page.php, and make these changes:

		if ( ! empty( $ftp->errors ) ) {
			do_action( 'boldgrid_backup_notice', implode( '<br /><br />', $ftp->errors ) );
			$success = false;
		} else {
			// UPDATE THE BELOW AND ADD $updated =
			$updated = update_site_option( 'boldgrid_backup_settings', $settings );
			// ADD THE BELOW LINE
			error_log( 'Updated successfully = ' . $updated );
			do_action( 'boldgrid_backup_notice', __( 'Settings saved.', 'boldgrid-backup' ), 'notice updated is-dismissible' );
		}

		return $success;

… in your error log we’ll see something like this:

[30-Apr-2020 19:49:17 UTC] Updated successfully = 1

Obviously if the setting is not saved successfully, then we can continue troubleshooting that path.

Thanks for all your help @badarmor !
– Brad

Thread Starter

(@badarmor)

After editing class-boldgrid-backup-admin-ftp-page.php as you suggested I’ve got this

The setting is not saved successfully. Still trying set from 3 to 2

This reply was modified 4 years, 10 months ago by Vyacheslav.

Plugin Author

(@bwmarkle)

When the retention is saved from 3 to 2, it is saved successfully:

[30-Apr-2020 20:49:38 UTC] Updated successfully = 1

Within W3 Total Cache, are you using database cache? If so, what caching engine are you using, is it disk?

Thread Starter

(@badarmor)

Within W3 Total Cache, are you using database cache? If so, what caching engine are you using, is it disk?

I use redis for database cache. Redis is installed at the localhost.

This reply was modified 4 years, 10 months ago by Vyacheslav.
This reply was modified 4 years, 10 months ago by Vyacheslav.

Thread Starter

(@badarmor)

I tryed to switch to disk method and even turn the database cache off completely. All the same.

Plugin Author

(@bwmarkle)