• Resolved eyeteeth

    (@eyeteeth)


    Hello, after upgrading to 3.12, it seems the gallery slideshow no longer works. Clicking on a gallery image just takes you to the image page rather than activating the slideshow. I verified this by reverting to an older version of MLA, the slideshow activates correctly when I revert to 3.09.

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author David Lingren

    (@dglingren)

    Thanks for your report.

    Can you share the full text of the shortcode you are using and the plugin that provides the slide show? That will help me reproduce the problem on my system so I can investigate further. Thanks for your help.

    Thread Starter eyeteeth

    (@eyeteeth)

    I have many galleries, I tried three when I noticed the problem. Here is the first one:

    [mla_gallery attachment_category=’never-gonna-get-it ‘ mla_link_attributes=’data-src=”{+file_url+}”, class=”lightbox-selector”‘ orderby=’name’ size=’comic-cover-thumb’]

    I apologize, it’s been so long since I installed everything I forgot that MLA does not provide the slideshow functionality. The slideshow is from https://www.lightgalleryjs.com/ which I believe is packaged with my theme. If you are able to locate the issue I would appreciate it but as it’s an interaction with someone else’s code I understand if you cannot.

    Thread Starter eyeteeth

    (@eyeteeth)

    I think I found the issue after re-updating to 3.12, the attributes provided by “mla_link_attributes” get &qout; inserted in place of quotation marks, with this result:

    data-src=”"https://www.eyeteeth.club/wp-content/uploads/2023/09/mob-vog-01-a698cabc.png",” class=”"lightbox-selector"”

    Is this an issue with my formatting of the mla_link_attributes values?

    Plugin Author David Lingren

    (@dglingren)

    Thank you for both your updates and especially for the work you did to identify the cause of the problem. I have reproduced the problem and confirmed that it is caused by an MLA defect I introduced in v3.10. A security enhancement was a bit too aggressive, and changed your quote marks to the corresponding HTML entity.

    I have uploaded a new MLA Development Version dated 20231024 that corrects the problem. You can find step-by-step instructions for using the Development Version in this earlier topic:

    How to download & install the current development version of MLA

    Once the Development Version is installed you can retest the handling of quotes in the mla_link_attributes shortcode parameter..

    The fix will be part of my next MLA version, but in the interim it would be great if you could install the Development Version and let me know if it works for you. Thanks for alerting me to this MLA defect.

    Thread Starter eyeteeth

    (@eyeteeth)

    Hello, with the dev version the slidshow works again. Thank you for looking into this!

    Plugin Author David Lingren

    (@dglingren)

    Thanks for giving the Development Version a try and confirming the fix. I will be updating MLA shortly and you will get the new version as usual. It’s safe to continue with the Development version until then.

    Plugin Author David Lingren

    (@dglingren)

    I have released MLA v3.13, which contains the fix required for this topic. I am marking the topic resolved, but please update it if you have problems or further questions regarding the handling of special characters in shortcode parameters.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Gallery slideshow stopped working with update 3.12’ is closed to new replies.