Generate Press, Infinite Scroll vs. Paginated

you’ll have to have ensure the infinite scroll JS calls ly.te() to render newly added vids and all will be fine Wolfram ??

hope this helps,
frank

Hey Frank, thanks a lot.

BUT: infinite scroll is a checkbox. I have no idea, what Tom Usborne does with it, which JS he’s calling ??

Or did I get you wrong, and you mean

echo do_shortcode(‘[ly.te id=’.$youtube_id.’]’);

instead of

echo do_shortcode(‘[lyte id=’.$youtube_id.’]’);

in my PHP code snippet, see above?

(yes, the only difference is that little dot between ly and te ??

Where / how else could I get access to this call, using GPP & GB?

Or did I get you wrong, and you mean

no ??

I’m afraid you’ll have to ask the question to GP; the issue is by default LYTE acts on the onLoad event (or domContentLoaded), but those don’t get triggered when doing infinite scroll, which is why some “glue” is needed to make sure the ly.te() gets called after the infinite scroll JS got more content.

Thanks again, I’ll try my very best to convince Tom ??

Say hi to Tom from me and tell him he can contact me if he needs more info ??

I’m sorry. I had no direct contact to Tom. His team finished this topic for now. So I have to fall back to the paginated archive, instead of infinite scroll.

Without GPP’s Infinite Scrolling, WP Lyte works like a charm. PageSpeed Insights scores 84. That’s not too bad, for vanilla hosting, no cache, just AutOptimize, so far.

Focussing on my little snippet again: could I further improve the Lyte call?

To me, it looks slightly over-complicated. But maybe, that’s my PHP allergy ??

Focussing on my little snippet again: could I further improve the Lyte call?

To me, it looks slightly over-complicated. But maybe, that’s my PHP allergy ??

looks OK to me, but do you _need_ those 2 output buffer calls?

You mean, unbuffered is good enough, like this?

add_shortcode( 'featured_youtube_video', function() {
    // ACF(featured_youtube_id, post_id)
    $youtube_id = get_field('featured_youtube_id', get_the_ID());
    if( $youtube_id ) {
        // WP Youtube Lyte
	echo do_shortcode('[lyte id='.$youtube_id.']');
    }
} );

I actually have no idea, what ob_* is doing here. I thought, this is kind of default, and required for such shortcode snippets.

don’t think it’s needed no, why not give it a quick test? ??

Of course ??

Done!

Very interesting result: WP Youtube Lyte works as before. You’re awesome, and you know it, I suppose …

BUT: The GenerateBlock content template gets disturbed. Calling Lyte without ob_*, pushes the video from last to top position.

The template is basically just a post title, consisting of

– Kicker (say headline of the headline)
– Headline
– Post Meta (Author, Date, Date)
– Subline (lead text, 1 or 2 lines)
– Featured Video

With ob_*, everything as expected.

Without ob_*, the video pops before the kicker. Everything else is fine.

Any idea, how I could fix that?

sure; keep the output buffer calls ??

My idea is, I could fix it by CSS.

But, generally, what’s the benefit of wrapping the call in ob_* ?

What’s the disadvantage, if I keep the buffer calls for proper sequence?

the disadvantage is kind of theoretical; output buffer is very powerful, but one small mistake in the code can have ugly consquences. if it works OK, there’s no reason to change it ??

Thank you so much, until next!

ahem, just to mark this resolved ??