Gift is not removed when adding coupon

Okay, so I have tried the following:

• Disabling all plugins except WooCommerce, ACF, Giftable for WooCommerce and Decom Small Giftable Coupon Alternative
• Removing all custom code in functions.php for the Storefront child theme
• Check if any js errors on the cart page. There are none.
• Clearing browser cache. Since I’m working locally there is no other caching. No caching plugins, no serverside caching.

So I tried something else. I changed line 31 in “giftable-for-woocommerce/includes/CriteriaAmounts.php” from WC()->cart->subtotal to WC()->cart->total. Now it works as expected, but I’m not sure if that change breaks other parts of the plugin.

If that really is the way to solve the issue, you could make the change yourself, test it and release an update for everyone to enjoy.

• This reply was modified 6 years, 7 months ago by jeppe.
• This reply was modified 6 years, 7 months ago by jeppe.
• This reply was modified 6 years, 7 months ago by jeppe.

Hi @jeppeskovsgaard, you are free to edit it in any way it suits your needs,
we don’t have time to test it right now with every condition and to change something, as we can create more errors or break other conditionals – and we are limited with our free time.

– If you are not using all conditions and if it’s working for you – then you are good to go then.

@decomteam

Alright. This works for me since I only use that condition and everything seems fine.

Thanks for responding quickly. ??

Just bumping this again, since I had to update and add my fix again 2 weeks ago when you pushed an update.

It would be great with an official fix, so that I can update without worrying. ??

Dear @jeppeskovsgaard, I will try to fix that in next release, maybe option to choose what you want in backend: total or subtotal count.
not promissing anything, but I will do my best

That sounds great. ??

Yea, an option would be better to suit all users needs.