Good but fix this bug

  • Working fine but I got a little bug, next and previous button isn’t like the bootstrap 3 and has positioning problem also

    I have fixed this bug, please replace this line with last line

    <a class="left carousel-control" href="#cptbc_<?php echo $id; ?>" data-slide="prev">?</a>
				<a class="right carousel-control" href="#cptbc_<?php echo $id; ?>" data-slide="next">?</a>

    correct code is below.

    <a class="left carousel-control" href="#cptbc_<?php echo $id; ?>" data-slide="prev"><span class="glyphicon glyphicon-chevron-left"></a>
				<a class="right carousel-control" href="#cptbc_<?php echo $id; ?>" data-slide="next"><span class="glyphicon glyphicon-chevron-right"></a>

    thank you

Viewing 1 replies (of 1 total)
  • Plugin Author Phil Ewels

    (@tallphil)

    Well spotted, looks like this is due to a change in the bootstrap core away from the original markup that I used from the beta..

    I’ve updated the code in github, it’ll go out with the next release. Note that the line you quoted is from the code used for Bootstrap version 2, so that particular line has remained unchanged.
    https://github.com/tallphil/cpt-bootstrap-carousel/commit/a8762ddc27f64d8182f8e715899bb42e329af8c2#diff-0

    Does this fix the positioning problem as well? As the plugin only provides the markup, positioning problems are usually due to styling problems. Let me know if you think that it’s the plugin’s fault though.

    Cheers,

    Phil

Viewing 1 replies (of 1 total)
  • The topic ‘Good but fix this bug’ is closed to new replies.