Hamburger menu

Hello @barsha04.
I’ve seen that last month your team released the update 1.3.0 of Himalayas theme. I’ve installed it and (as I expected) the problem we reported was still present.
Since I’m a computer programmer too, I decided to take matters into my hands and to find a solution by myself. I solved the problem replacing a single line of code inside the script himalayas.js (I didn’t now I could edit javascript files directly inside WordPress). The culprit was the jQuery instruction

jQuery( window ).on( 'load', function () {

which, as documented in https://learn.jquery.com/using-jquery-core/document-ready/ , allows to run the code inside the function only once the entire page (images or iframes), not just the Document Object Model (DOM), is ready.
Probably for some reason there were some elements on the page which were not correctly loaded, causing the “load” event to never happen. I solved the problem replacing the instruction with this one:

jQuery( document ).ready( function () {

This instruction makes the function run only once the page DOM is ready for JavaScript code to execute, without waiting for images, iframes, etc. to load.

So, I’m disappointed because I reported this problem many times for the last two years and the answer was always that the team was working on it. I’ve waited for all this time with no success, and then I solved the problem in a few hours without knowing your code. Since the problem is present also in your demo example, I think your team could have solved the issue with minimal effort.
I hope at least you will copy my solution in the official code, so if there will be any future updates of the theme, they will not overwrite my new instruction. I also hope that for the future there will be more transparency in the communications, i.e. if the team is not willing to solve the problem because it’s working on other higher priority activities, I’d prefer you say it clearly, so next time I don’t wait in vain.
Thank you anyway.

With regards.

• This reply was modified 1 year, 1 month ago by lorenzoing1.

Hi there @lorenzoing1,

I was facing this same problem. Spent a few hours trying to solve it until I came across your post. Thanks very much for sharing your solution!!! Finally the hamburger menu is working again.

What I can’t understand:

1. Why didn’t Himalayas / @barsha04 even thank you for all your work and the solution you provided for this very serious problem?
2. Why, after all these months, is the non-working code still offered for download by Himalayas?

Anyway, thanks again, you saved my day. Good job!

Plimfec

Interesting! When you say you can edit javascript files directly inside WordPress, do you mean there’s a tool within my WordPress dashboard? Or, do I look for a javascript file in the account control center for my web host?

@barsha04 Barsha, I thought the problem was jetpack, so I did not reinstall it. But the problem continues. The Hamburger Menu does not work consistently on mobile devices. Here’s my site: https://jackiecraven.com

Hi @jackiecraven,

If you have FTP access to your website, just replace the himalayas.js file using FTP.

1)
Download the Himalayas theme and unpack it.
Path to himalayas.js file is:

himalayas.1.3.0 > himalayas > js > himalayas.js

2)
Open the himalayas.js file and run a search for: 

jQuery( window ).on( 'load', function () {

Replace this line with the one given by @lorenzoing1:

jQuery( document ).ready( function () {

3)
Save the file and use FTP to upload your modified himalayas.js to its right location on the server. Which is:

wp-content > themes > himalayas > js

4)
Done.

Finally save your modified himalayas.js locally, so that after any update of Himalayas in which the problem is not fixed, you can once again fix it yourself easily.

Good luck,
Plimfec

Thank you, @plimfec. I’ll try this. I usually install themes directly within my WordPress dashboard instead of downloading, but this sounds do-able.