HAmburger not working with AMP v 1.1.0

  • Resolved craigstanfield

    (@craigstanfield)


    5 years, 10 months ago

    Hi All,

    I’ve recently upgraded my AMP plugin from v0.7 to v1.1 however All my existing templates and work to get amp to work as needed is not being used anymore. I’m pretty happy with the result that i get with v1.1 in paired made but the hamburger menu just reloads the page without showing the menu.

    In my v0.7.2 version i had a call to the amp-sidebar library from it’s amp header template. How can one extend the functionality into a custom template like we could in v0.7.2 by adding a custom filter in functions.php ie
    add_filter( ‘amp_post_template_file’, ‘my-amp’);

    thanks

    The page I need help with: [log in to see the link]

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Pascal Birchler

    (@swissspidy)

    Please have a look at the documentation on how to create AMP compatible hamburger menus: https://amp-wp.org/documentation/playbooks/toggling-hamburger-menus/

    Looking at your site it should be quite easy, as all that needs to be changed is the aria-expanded attribute on the menu, as well as toggling the move-left class on the off-canvas-wrap.

    The documentation contains two examples. Either should work for your use case, but perhaps the one at the bottom of the page is easier to grasp.

    Thread Starter craigstanfield

    (@craigstanfield)

    Thanks Pascal,

    I’ll get that in place. I had noticed this page while looking over docs but was thinking I may be able to reuse my old template. However if it’s worth doing it’s worth doing right.

    thanks

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘HAmburger not working with AMP v 1.1.0’ is closed to new replies.