• Resolved hatisenang

    (@hatisenang)


    Hi, I noticed at least on new pages/posts when the Block Editor is disabled, i.e. when using the Classic Editor, the Edit in Breakdance button doesn’t work when the Heartbeat Control setting from this plugin is set to ‘disable’. I haven’t tested with the limit settings but it works fine when the Heartbeat Control setting is toggled off.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Bowo

    (@qriouslad)

    What did you disable? The Heartbeat Control module itself? Or, one of the options in it?

    Screenshots would help. Also, any JS error you see in the browser console, while you’re in Breakdance.

    Thread Starter hatisenang

    (@hatisenang)

    Sorry for the late reply. I’ve done a little more testing and can confirm that only option causing this issue is “On post creation and edit screens” is set to “Disable”. All other options from the Heartbeat Control module do not cause this error.

    Although disabling the Heartbeat Control module itself does prevent the error, simply changing the “On post creation and edit screens” option to either “Keep as is” or “Modify” also works.

    So, when the Heartbeat Control module is enabled and the “On post creation and edit screens” is set to “Disable”, that is when the Edit in Breakdance button stops working and JS errors coming from the following file: /wp-content/plugins/breakdance/plugin/admin/launcher/js/shared.js?ver=2.2.0 which seem to be directly related to the issue show up in the browser console. Screenshot of JS erros: https://snipboard.io/64XRtW.jpg

    Plugin Author Bowo

    (@qriouslad)

    @hatisenang thanks for reporting back with more details. From the JS error that says “wp.autosave is undefined”, it does appear that the scritps related to the “Edit in Breakdance” button is dependent on Heartbeat API working / available on the edit screen. The primary purpose of the Heartbeat API in edit screens is in fact to provide the auto-save functionality.

    So, this is not a bug in ASE, but simply an expected behaviour due to how Breakdance requires Heartbeat API to be available. Moreover, I don’t see why you would need to completely disable the Heartbeat API. Simply setting it to a longer duration than the default 15 seconds should already provide benefits in terms of reducing CPU load, which in turn may speed up wp-admin load times for sites with many authors doing routine editing work but is on a low-powered (maybe shared) hosting environment.

    Thread Starter hatisenang

    (@hatisenang)

    OK. I understand now that this is not a bug in ASE and is actually the expected behavior, thanks to your detailed explanation. It’s also great to know that setting a longer duration for the Heartbeat API is enough to prevent wp-admin from slowing down.

    I would like to take this chance to thank you very much for creating such an amazing plugin. ASE has become one of my favorite WP plugins of all time. Please keep up the great work and may you have a wonderful time doing so.

    Plugin Author Bowo

    (@qriouslad)

    You’re most welcome, and my pleasure.

    If it’s not too much trouble, please kindly copy what you wrote above as a quick review for ASE at https://www.ads-software.com/plugins/admin-site-enhancements/#reviews which would help support the project move a little bit forward. Thank you.

Viewing 5 replies - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.