Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Takayuki Miyauchi

    (@miyauchi)

    Hi saas,

    I didn’t see this ticket.
    I’ll make some patches, please wait. ??

    Thread Starter saas

    (@saas)

    Hi Takayuki Miyauchi,
    I see.
    Good, looking forward to see that.

    Plugin Author Takayuki Miyauchi

    (@miyauchi)

    Hi saas,

    Do you think about this patch?
    Please try and post feedback. ??

    https://core.trac.www.ads-software.com/ticket/6331#comment:31

    Thread Starter saas

    (@saas)

    Hi Takayuki,
    I saw your patch, and glad you did it.

    And I tested latest v3.9 beta and your patch, it works fine.

    And I agree with @nacin on this, as you don’t need a dialog box for pre.

    Otherwise its working fine.

    I think you should keep it simple,

    don’t assume / detect anything in your code (like whether I should wrap “code” or “pre” around selected text, instead why not provide dropdown selection (similar to “Text Color” button, which list down colors), so you can show pre / code as two option and leave it upto the user to select which one, as the user who is going to use code / pre tags will surely be the one who knows what they do, and will have to select either function name, tag or word for applying code tag (inline) or for block level pre they have to select multiline text etc.

    I am hoping my suggestion is useful for you.

    Plugin Author Takayuki Miyauchi

    (@miyauchi)

    You have a point there, I will create a new patch.
    So, I will be removed <pre/> support.

    Thanks. ARIGATOU !

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘How about sending a pull request to core code?’ is closed to new replies.