Hey Purnendu,
That’s gr8. Thanks for accepting this so quickly. ??
You may consider returning the $vendor
object instead of $vendor_id
(and rename the function accordingly).
- So that it matches the way we get shop URL from vendor ID: first get the vendor object and then access required property. (as you posted earlier)
- Currently its fulfilling my specific need but when you return vendor object, it will become more generic and allow accessing other properties of vendor object more easily. That might be helpful to other users.
I don’t think I need to tell you this, but just in case if you have missed it, you may want to remove hardcoded dc_vendor_shop
and use $WCMp->taxonomy->taxonomy_name
:).
I used the hardcoded value just because I wanted to get confirmation if my approach is right or not, but yes, I should have used that property myself ??
Kindly let us know if you have any other suggestion.
I’ve already sent few mails to ‘Plugins DC’ mail ID. To be specific 6 emails with couple suggestions and 15/16 issues (UI + functionality related). But I have got response only once. (I was expecting more responses like issue accepted/rejected; clarification / more info needed; etc.) If someone can take a look at those mails and respond, that will boost my confidence that my mails are being read and acted upon. ??
Btw is there any ETA for v3.0?