How to show multiple CPT by category in custom archive page?

The key is the ‘pre_get_posts’ hook. It is expanding the post types queried correctly, but it is only applying this to actual category and tag requests, not any other archive requests. Try changing
if( ( $query->is_category() || $query->is_tag() ) ) {

to this:
if( ( $query->is_archive ) ) {

This will possibly need further adjustment to screen out other conditions, but any archive pages should now show both post types.

The real challenge is sorting by category. Category is not an orderby option when using WP_Query, the default query method. Doing so would require a more complex SQL query that I’m unsure how to write. If you can determine how one is written, using the query means completely replacing the WP query with yours using the ‘posts_request’ filter.

The ‘posts_request’ filter can be added within the conditional in ‘pre_get_posts’ so that it is not applied to other queries.

A very poor PHP alternative to a custom SQL query is to get all the categories and do a separate query for each category.

The question of how to sort by categories seems to keep coming up, so I challenged my SQL skills to come up with a functional SQL query for this. I ended up with this:

//query for all posts, products, & news w/ categories ordered by category name
global $wpdb;
$query = $wpdb->get_results( "SELECT * FROM $wpdb->posts AS p
	LEFT JOIN $wpdb->term_relationships AS r ON (p.ID = r.object_id)
	INNER JOIN $wpdb->term_taxonomy AS x ON (r.term_taxonomy_id = x.term_taxonomy_id)
	INNER JOIN $wpdb->terms AS t ON (r.term_taxonomy_id = t.term_id)
	WHERE p.post_type IN ('post', 'product', 'news') 
	AND p.post_status = 'publish'
	AND x.taxonomy = 'category'
	ORDER BY t.name ASC, p.post_date DESC" 
);

Anything without a category will not be returned. Posts with multiple categories will appear once for each category.

As I mentioned previously, you can use the ‘posts_request’ filter to replace the default query with this one, but only do so under certain conditions.

Alternately, put this query on a template and run a custom loop to handle the output.

Thanks bcworkz for your concern. But the problem still remains the same. I can view cpt “Product” but for the cpt “news” it is not showing the content of archive-news.php.

I’ve also changed as you mentioned.
if( ( $query->is_archive ) ) {

At least it should display archive-news.php. It’s just displaying the same page (archive.php). May be my archive page contains error. Just please check it out I’ve pasted as it is on my archive.php. Maybe you could figure out the problem.

<h2 class="page-title"><?php if ( have_posts() ) : ?><span><?php the_archive_title( '', false ); ?></span> <?php the_archive_description( '<div class="taxonomy-description">', '</div>' ); ?></h2>
				
<div class="clear"></div>

<div class="grids_of_3">
<?php
// Start the Loop.
while ( have_posts() ) : the_post();
?>

<div class="grid1_of_3">
<?php
$id = get_the_id(); //Get Post ID
$featured_image_id = get_post_meta($id, '_thumbnail_id', 1); //Retrieve the featured image id, having key as _thumbnail_id
if($featured_image_id !=''){
$attachment = wp_get_attachment_image_src($featured_image_id, 'medium', false); // it gives array having first parameter source, second parameter width and third parameter height with image sizes: thumbnail, medium, large and full. 
if(count($attachment) > 0) {
?>
<a href="<?php the_permalink(); ?>"> 
<img class="img-responsive" src="<?php echo $attachment[0]; ?>" width="<?php echo $attachment[1]; ?>" height="<?php echo $attachment[2]; ?>" />
<h3><?php the_title(); ?> </h3>
</a>								
</div>
<div class="clearfix"></div>
<?php
}
}
?>
<?php
// End the loop.
endwhile;
// Previous/next page navigation.
echo"<div style='clear:both'>&nbsp;</div>";
echo '<div class="clearfix"></div>';
// Previous/next page navigation.
the_posts_pagination( array(
'prev_text'          => __( '<<', 'twentysixteen' ),
'next_text'          => __( '>>', 'twentysixteen' ),
'before_page_number' => '<span class="meta-nav screen-reader-text">' . __( '', 'twentysixteen' ) . ' </span>',
'screen_reader_text'          => __( '&nbsp;', 'twentysixteen' ),
) );
// If no content, include the "No posts found" template.
else :
get_template_part( 'template-parts/content', 'none' );
endif;
?

• This reply was modified 8 years, 2 months ago by jklyn.
• This reply was modified 8 years, 2 months ago by jklyn.