• Resolved Mike

    (@grandjil)


    Hi Yannick,

    after the update from last night the HTML coding is not working anymore, now my pages are messed up…

    On this page /wp-admin/edit.php?post_type=link_library_links&page=link-library-settingssets en then i go to the tab Advanced – before i had coding in this template like

    • before a link and after a link i had
    • also codes like </br> are not working anymore

      How can i fix this?

Viewing 15 replies - 1 through 15 (of 22 total)
  • Thread Starter Mike

    (@grandjil)

    `i mean <li> before the link and </li> after the link

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    Indeed, it looks like the functions I used to add security validation to the plugin were a bit too extreme and did not allow HTML tags to be used in the plugin’s advanced tab. This has been corrected in version 7.4.2. Please update and fix up these HTMl tags and you should be good. If not, let me know and I will investigate further tomorrow.

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    Did further improvements to accepted HTML tags in 7.4.3. Let me know if any tag you were using does not work correctly and please consider donating to support this plugin’s development.

    Thread Starter Mike

    (@grandjil)

    Hi Yannick,

    it’s working well again.

    Thanks for the fast fix

    With kind regards

    Mike

    I updated to 7.4.3 and it also messed up the html output.

    • This reply was modified 1 year, 11 months ago by slabbi.
    Plugin Author Yannick Lefebvre

    (@jackdewey)

    If you saved your settings with version 7.4.1, you will need to recreate your HTML configuration under the plugin Advanced Configuration tab, since all HTML tags have been lost.

    Yes, I recognized that.
    I am not sure if it still seams to clean html tags too aggressively since after restoring the tags the output broke again.
    Though after installing 7.4.3 and restoring the configuration it seems to work now (not tried to save the configuration, I am glad that it works again).

    • This reply was modified 1 year, 11 months ago by slabbi.
    Plugin Author Yannick Lefebvre

    (@jackdewey)

    Can you indicate which tag(s) you were using and in what field?

    The tags that are currently allowed in version 7.4.3 are the following:

    function allowed_html_tags() {
    		return array(
    			'a' => array(
    				'href' => array(),
    				'title' => array(),
    				'class' => array(),
    				'data' => array(),
    				'rel' => array(),
    		  	),
    			'abbr' => array(
    				'title' => array(),
    			),
    			'acronym' => array(
    				'title' => true,
    			),
    			'b' => array(),
    			'blockquote' => array(
    				'cite' => array(),
    			),
    		  	'br' => array(),
    			'cite' => array(
    				'title' => array(),
    			),
    			'code' => array(),
    			'del' => array(
    				'datetime' => array(),
    				'title' => array(),
    			),
    			'dd' => array(),
    			'div' => array(
    				'class' => array(),
    				'data' => array(),
    				'style' => array(),
    		  	),
    		  	'em' => array(),
    			'dl' => array(),
    			'dt' => array(),
    			'em' => array(),
    			'h1' => array(),
    			'h2' => array(),
    			'h3' => array(),
    			'h4' => array(),
    			'h5' => array(),
    			'h6' => array(),
    			'hr' => array(),
    			'i' => array(),
    			'img' => array(
    				'alt'    => array(),
    			  	'class'  => array(),
    			  	'height' => array(),
    			  	'src'    => array(),
    			  	'width'  => array(),
    		  	),
    			'li' => array(
    				'class' => array(),
    		  	),
    			'ol' => array(
    				'class' => array(),
    		  	),
    			'option' => array(
    				'value' => array(),
    				'selected' => array(),
    			),
    			'p' => array(
    				'class' => array(),
    			),
    			'q' => array(
    				'cite' => array(),
    				'title' => array(),
    			),
    		  	'ul' => array(
    				'class' => array(),
    		  	),
    			'select' => array(
    				'id'   => array(),
    			  	'class' => array(),
    			  	'name' => array(),
    		  	),
    		  	'span' => array(
    				'class' => array(),
    				'title' => array(),
    				'style' => array(),
    			),
    			'strike' => array(),	  	
    		  	'strong' => array(),
    		);
    	}
    Plugin Author Yannick Lefebvre

    (@jackdewey)

    I saw you edited the reply saying that it’s working. So everything is back to normal now?

    Hello Yannick,

    I’m having a similar problem. Now when I save an HTML tag with a class, it disappears directly.
    Example: I can add a <div> tag, but I cannot add a <div class=”linkbox”> tag.

    Would it be possible to solve this problem please?

    (Sorry if my English is bad, I use Google Translate.)

    No, it is not yet working, sorry.

    I am missing following tags:
    tr,
    tr with style,
    td,
    td with style,
    ol,
    img with style,

    and the corresponding closing tags.

    • This reply was modified 1 year, 11 months ago by slabbi.

    Maybe you should not filter tags at all but filter some maybe critical tags instead, e.g. script?

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    The utility function provided by WordPress (wp_kses) is designed to specify tags to keep, not tags to remove. And WP Scan has been working hard to get people to harden their plugins.

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    Please update to version 7.4.5. All tags mentioned should now be supported.

    No, sorry. The Link Library now escapes the tags.
    I will send you some pics.

Viewing 15 replies - 1 through 15 (of 22 total)
  • The topic ‘HTML is not working anymore’ is closed to new replies.