I18N Issue

  • Resolved Alex Lion (阿力獅)

    (@alexclassroom)


    2 years, 11 months ago

    Hi Developer,

    If you have more than one placeholder in a string, it is recommended that you use argument swapping. Please refer to this official tip.

    Like the above suggestion, class-r34nono.php line 157 should be modified as the following:
    'description' => sprintf(__('Removes the selected %1$s tags from the %2$s on all front-end pages.', 'no-nonsense'), '<code><link></code>', '<code><head></code>'),
    Then my zh_TW translation can be “從全部前端頁面的 %2$s 中移除選取的 %1$s 標籤。”

    templates\admin\r34nono-admin.php line 100 should be modified as the following:
    <p><?php echo sprintf(__('For support with the %1$s plugin, please use the %2$sWordPress Support Forums%3$s or email %4$s.', 'no-nonsense'), '<strong>No Nonsense</strong>', '<a href="https://www.ads-software.com/support/plugin/no-nonsense" target="_blank">', '</a>', '<a href="mailto:[email protected]">[email protected]</a>'); ?></p>

    class-r34nono.php line 61 should be modified as the following:
    'description' => sprintf(__('Hides the admin bar on front-end pages for logged-in users with no editing capabilities. Admin bar will still display for these users when they access their profile page. %1$sNote:%2$s With this option turned on, you will need to provide another way on the front end of your site for logged-in users to access their profile page and the logout link.', 'no-nonsense'), '<strong>', '</strong>'),

    class-r34nono.php line 229 should be modified as the following:
    'description' => sprintf(__('Most WordPress sites do not use XML-RPC, although some plugins (e.g. Jetpack) and mobile applications may require it. Per changes in WordPress 3.5, turning this option on will only disable XML-RPC requests that require authentication. Use the %1$sAlso kill any incoming XML-RPC request%2$s option below to cause all incoming XML-RPC requests to exit early. (Note: Because this is a plugin-based solution, XML-RPC requests still must partially load, to the point where this plugin is active, before it can kill the process. For better performance during a DDOS attack, you may wish to block calls to %3$s directly in your site&rsquo;s %4$s file.', 'no-nonsense'), '<strong>', '</strong>', '<code>xmlrpc.php</code>', '<code>.htaccess</code>'),

    And templates\admin\r34nono-admin.php line 108 can be localized, it should be modified as the following:
    <h3 class="hndle"><span><?php _e('Thank You!', 'no-nonsense'); ?></span></h3>

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    class-r34nono.php line 246 should be modified as the following:
    'description' => sprintf(__('Skips installing things like new themes that are bundled by default with WordPress core upgrades. This can also be handled manually by adding the %1$sCORE_UPGRADE_SKIP_NEW_BUNDLED%2$s constant in your %3$swp-config.php%4$s file.', 'no-nonsense'), '<code>', '</code>', '<code>', '</code>'),

    Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    class-r34nono.php line 124 should be modified as the following:
    'description' => sprintf(__('Removes links to Comments in the admin bar and admin sidebar menu. Does not actually deactivate comment functionality; this should be done under %1$sSettings %2$s Discussion%3$s.', 'no-nonsense'), '<a href="' . admin_url('options-discussion.php') . '" target="_blank">', '>', '</a>'),

    Plugin Author room34

    (@room34)

    Thanks, I was not aware of this. Will correct in the next update.

    Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    class-r34nono.php line 199 should be modified as the following:
    'description' => sprintf(__('If you use WordPress as a general-purpose CMS without a blog component, this option will hide the Posts link in the main admin navigation. It does %1$snot%2$s deactivate the "Posts" post type itself, nor restrict any front-end content. If you are using an SEO plugin, you will need to adjust its settings to exclude Posts from your sitemap XML.', 'no-nonsense'), '<strong>', '</strong>'),

    Plugin Author room34

    (@room34)

    Thank you. I understand the principle of the change that needs to be made to all translation strings throughout the plugin; you don’t need to provide any more examples. This will be fixed in the next update.

    Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    Sorry for bothering you, the above are all of current strings that need to be modified.

    If this plugin has public repository, I will submit PR in the future.

    Plugin Author room34

    (@room34)

    Version 1.6.0 has all of the sprintf() placeholders corrected. It also has the text domain path defined and includes a .pot file.

    I was caught off guard by the quick adoption of this plugin; I hadn’t finished setting up all of the i18n support because with my past plugins I had a lot of time to sort things out before there was any demand for it.

    Plugin Author room34

    (@room34)

    @alexclassroom By the way, thanks for the kind review!

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘I18N Issue’ is closed to new replies.