if (! empty( $attr['type']) && $attr['type'] == 'native') BUG

  • Could not edit my first ticket, so here is the same one after the edidt.

    if (! empty( $attr['type']) && $attr['type'] == 'native') {
	// returning nothing will make gallery_shortcode take over
	return '';
}

    The if statement should be updated to just:

    if (!empty($attr['type']) && $attr['type'] != 'rgg'){return '';}

    Because if I have some special type to do something else, your plugin breaks it. You should not assume that type is not being used by other functions or plugins…

    https://www.ads-software.com/plugins/responsive-gallery-grid/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter radi_v

    (@radi_v)

    Updated. Please see my other ticket.

    Plugin Author Jules Colle

    (@jules-colle)

    Good point. The problem however is that I want all native wordpress galleries to become responsive galleries out of the box, without having users to specify this one by one. I could maybe drop the type parameter and introduce a parameter called disable_rgg instead that would need the value true in order to disable the responsive gallery.

    Will think about it.

    EDIT: oh wait, your code seems like it’s what I need. If the type parameter is omitted, RGG will be used as well. Great stuff. Thanks

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘if (! empty( $attr['type']) && $attr['type'] == 'native') BUG’ is closed to new replies.