If the title is empty for the Portfolio widget, the title is still output

  • Resolved alexgso

    (@alexgso)


    7 years, 6 months ago

    Hey guys,

    A user has reported an instance of undesired spacing that cannot be removed without CSS in the Livemesh Portfolio widget. If the portfolio title is empty, the title markup (being an h3 with margin-bottom applied) is still present on the page. There is an empty() check (reference) for the title but it doesn’t seem to matter if $header is empty or not as the h3 is still output.

    Semi-related but, is this the preferred place for these types of reports?

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author livemesh

    (@livemesh)

    Although we had an empty check in place, there is a bug in the code which makes the check not take effect. Have fixed this in the dev version. Will make sure this is part of upcoming update.

    Meanwhile, if you want to just do a quick fix, pls modify includes/widgets/lsow-portfolio-widget/tpl/default.php, replace line numbers 35 to 37 with below code – 

                <?php if (!empty($heading)) : ?>

                <h3 class="lsow-heading"><?php echo wp_kses_post($heading); ?></h3>

            <?php endif; ?>
    Thread Starter alexgso

    (@alexgso)

    Hi Livemesh,

    Awesome stuff – thanks! ??

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘If the title is empty for the Portfolio widget, the title is still output’ is closed to new replies.

Tags