@import in CSS comment (Genesis)

  • Resolved iWPer

    (@iwordpresser)


    8 years, 5 months ago

    Hi,

    Great plugin!!! Thank you!

    In version 2.1.0 (coming from 2.0.2), Autoptimize reads/prints (some) CSS as CSS, even if it resides inside a CSS comment.

    For example, the Genesis framework starts its CSS file with a comment containing a warning:

    /* # WARNING

    This file is part of the core Genesis Framework. DO NOT edit this file under any circumstances. Please do all modifications in the form of a child theme.
    Copy the contents of this file to the child theme. Do not use @import, as the CSS included with Genesis might change in the future.

    */

    Where “@import, as the CSS included with Genesis might change in the future.” is recognized as CSS and used in the minimized/combined CSS file. This results in:

    @import, as the CSS included with Genesis might change in the future.@import url(//fonts.googleapis.com/css?family=Lato:300,400,700);

    Which should have been:

    @import url(//fonts.googleapis.com/css?family=Lato:300,400,700);

    I hope this can be fixed in a new version.

    Thank you

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Frank Goossens

    (@futtta)

    ok, I’ll look into that. but is this a regression (as in; did no happen in 2.0.2) or did you just happen to notice this now?

    frank

    Thread Starter iWPer

    (@iwordpresser)

    Thanks.

    This did not happen in 2.0.2. I noticed and checked after the update messed up the layout, because the font was not loaded.

    Regards

    Plugin Author Frank Goossens

    (@futtta)

    ok @iwordpresser, I was able to reproduce and have this (potential) fix in on Github; could you test (just 2 characters to change in autoptimize/classes/autoptimizeStyles.php) to confirm?

    frank

    Thread Starter iWPer

    (@iwordpresser)

    Hi Frank,

    Your fix worked for me! Thank you for your quick help!!
    Can I use this fix now and expect the next update to include it?

    Have a good weekend!

    Plugin Author Frank Goossens

    (@futtta)

    Your fix worked for me! Thank you for your quick help!!

    great, thanks for confirming!

    Can I use this fix now and expect the next update to include it?

    yes and yes ??

    have a nice weekend,
    frank

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘@import in CSS comment (Genesis)’ is closed to new replies.