• Resolved Alex Lion (阿力獅)

    (@alexclassroom)


    I found several I18N issues and provided the modifications as the following.

    ip2location-redirection.php, Line 9, this is a must-fixed issue, or the language pack will not work. Please notice the dot is unnecessary in the original header.

     * Text Domain: ip2location-redirection

    ip2location-redirection.php, Line 74 to 77

    add_menu_page(__( 'Redirection', 'ip2location-redirection' ), __( 'Redirection', 'ip2location-redirection' ), 'manage_options', 'ip2location-redirection', [$this, 'rules_page'], 'dashicons-admin-ip2location', 31);
    add_submenu_page('ip2location-redirection', __( 'Rules', 'ip2location-redirection' ), __( 'Rules', 'ip2location-redirection' ), 'manage_options', 'ip2location-redirection', [$this, 'rules_page']);
    add_submenu_page('ip2location-redirection', __( 'IP Lookup', 'ip2location-redirection' ), __( 'IP Lookup', 'ip2location-redirection' ), 'manage_options', 'ip2location-redirection-ip-lookup', [$this, 'ip_lookup_page']);
    add_submenu_page('ip2location-redirection', __( 'Settings', 'ip2location-redirection' ), __( 'Settings', 'ip2location-redirection' ), 'manage_options', 'ip2location-redirection-settings', [$this, 'settings_page']);

    ip2location-redirection.php, Line 90 to 92

    <p>
    ' . sprintf(__('IP2Location Redirection requires the IP2Location BIN database to work. %1$sSetup your database%2$s now.', 'ip2location-redirection'),'<a href="' . get_admin_url() . 'admin.php?page=ip2location-redirection">','</a>') . '
    </p>

    ip2location-redirection.php, Line 841 to 843

    <p>
    ' . sprintf(__('%1$sIP2Location Redirection%2$s is a plugin to redirect visitor by their location.', 'ip2location-redirection'),'<strong>','</strong>') . '
    </p>

    ip2location-redirection.php, Line 1757 (There is an unnecessary “e” in the original code)

    <input type="button" id="ip2location-redirection-submit-feedback-button" class="button button-danger" value="' . __('Submit & Deactivate', 'ip2location-redirection') . '" />
Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
  • The topic ‘Improve I18N Issues (Based on 1.28.1)’ is closed to new replies.