Improve I18N Issues (based on version 3.3.3)

  • Resolved Alex Lion (阿力獅)

    (@alexclassroom)


    1 year, 10 months ago

    I found several I18N issues, and I listed modified code as the following.

    \includes\customizer\controls\class-ogf-customize-upsell-control.php

    Line 32

    <h2 class="upsell__title"><?php esc_html_e( 'Upgrade to Fonts Plugin Pro', 'olympus-google-fonts' ); ?></h2>

    Line 34 to 37

    <li><?php esc_html_e( '?</img> Unlock Font Size & Color', 'olympus-google-fonts' ); ?></li>
<li><?php esc_html_e( '??</img> Host Fonts Locally', 'olympus-google-fonts' ); ?></li>
<li><?php esc_html_e( '??</img> Optimized Font Loading', 'olympus-google-fonts' ); ?></li>
<li><?php esc_html_e( '??</img>? Upload Custom Fonts', 'olympus-google-fonts' ); ?></li>

    Line 39

    <a class="upsell__button button button-primary" href="https://fontsplugin.com/pro-upgrade/?utm_source=plugin&utm_medium=customizer&utm_campaign=<?php echo esc_attr( $this->section ); ?>" target="_blank"><?php esc_html_e( 'Learn More', 'olympus-google-fonts' ); ?></a>

    \includes\customizer\controls\class-ogf-customize-multiple-fonts-control.php

    Line 68

    <select data-placeholder="<?php esc_attr_e( 'Choose some fonts...', 'olympus-google-fonts' ); ?>" multiple class="ogf-select" data.link>

    includes\customizer\panels.php

    Line 78

    'description' => __( 'Optimize your site\'s performance by unchecking any font weights you don\'t need.', 'olympus-google-fonts' ),

    includes\customizer\class-ogf-optimization-controls.php

    Line 46

    'description' => __( '<p>Optimize the delivery of font files for improved performance and user-privacy.</p><p>Upgrade to <a >Fonts Plugin Pro</a> to unlock these features.</p>', 'olympus-google-fonts' ),

    Line 75

    'description' => sprintf (esc_html__( 'Fonts will be served from %s instead of fonts.googleapis.com.', 'olympus-google-fonts' ),$url),
Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    Additional Modifications

    admin\class-ogf-welcome-screen.php

    Line 79

    <h1><?php esc_html_e( 'Your Quickstart Guide', 'olympus-google-fonts' ); ?></h1>

    Line 83 to 84

    <p><?php esc_html_e( 'To help you get the most out of the Google Fonts plugin we’ve put together a free quickstart guide.', 'olympus-google-fonts' ); ?></p>
<p><?php esc_html_e( 'In this beautifully-formatted, easy-to-read PDF you will learn:', 'olympus-google-fonts' ); ?>

    Line 86 to 88

    <li><?php printf(esc_html__( 'How to %1$seasily%2$s customize your typography.', 'olympus-google-fonts' ),'<strong>','</strong>'); ?></li>
<li><?php printf(esc_html__( 'How to host fonts %1$slocally%2$s for speed, GDPR & DSGVO.', 'olympus-google-fonts' ),'<strong>','</strong>'); ?></li>
<li><?php printf(esc_html__( 'How to use Google Fonts without %1$sslowing down%2$s your website.', 'olympus-google-fonts' ),'<strong>','</strong>'); ?></li>

    Line 90

    <p><?php esc_html_e( 'Download your free copy today.', 'olympus-google-fonts' ); ?></p>

    Line 94

    <input type="email" value="" placeholder="<?php esc_attr_e( 'Your email address...', 'olympus-google-fonts' ); ?>" name="email" class="required email" id="mce-EMAIL">

    Line 97

    <input type="submit" value="<?php esc_attr_e( 'Send My Guide!', 'olympus-google-fonts' ); ?>" name="submit" class="ogf-send-guide-button button">

    Line 101

    <a class="ogf-send-guide-button button"  target="_blank"><?php esc_html_e( 'Read Guide', 'olympus-google-fonts' ); ?></a>
    Plugin Author DannyCooper

    (@dannycooper)

    Thanks @alexclassroom! I will get these implemented as soon as possible.

    If it’s easier for you (now or in future), you can submit pull requests directly here – https://github.com/fontsplugin/plugin

    Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    Sorry for late reply. I got a cold so I’m not well yesterday. I will submit a PR later.

    Plugin Author DannyCooper

    (@dannycooper)

    Thanks again @alexclassroom, merged in 3.3.4

    Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    I also updated the latest zh_TW translations for this awesome plugin.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Improve I18N Issues (based on version 3.3.3)’ is closed to new replies.