Incoming version 1.0.3

I had a bug report come in today regarding rewrite parameters, and it was part of what was likely causing so much need for rewrite flushing and resaving of values. Specifically the with_front was not always being properly set.

If you’re willing to help me test this, I’d greatly appreciate it.

If you would like to help, especially if you have a dev site, download and install https://github.com/WebDevStudios/custom-post-type-ui/archive/master.zip

This should be taken care of once 1.0.3 is out, but if you are having rewrite issues, and you re-save your post type/taxonomy settings, the issue should go away. A big issue ended up being that the stored value of a numeral zero prevented part of the rewrite arguments, and I have the numeral zero being converted to “false” on save.

Darn nuances.

Hi Michael,

I have some suggestions on one thing, the help icons.

I actually took it upon myself to use Font Awesome, and it works great. I added the Font Awesome files, changed the way the A tag gets implemented, and updated the help icon CSS to color: inherit.

IMHO Looks a little more professional with HTML icons rather than images.

Also, since WP uses Dashicons, that could also be an effective way to implement the ? icon next to the Label.

somethumb, are you on GitHub at all? I’d be interested in seeing a PR for this. If it’s definitely deemed a better solution than what I have now, I’d definitely pull it in for 1.1.

I’m also wanting to rework how the help icons/text is done as a whole, as it’s definitely not intuitive right now.

I did run in to this issue just last night!!! It was actually with the has_archive toggle. I had to change it then save, refresh/leave the edit screen, and sometimes I had to do that 2 to 3 times to get it to work… Will this update fix this one as well?

has_archive should be covered.

$has_archive = get_disp_boolean( $post_type['has_archive'] );
if ( !empty( $post_type['has_archive_string'] ) ) {
	$has_archive = $post_type['has_archive_string'];
}

first line does the boolean version, and if there’s a string value saved, that gets saved to the value instead, to be passed in.

Curious if it needs to he trimmed.

I’m not exactly an expert in Github, but I’ll learn. Meanwhile, I can provide some suggestions right here:

First, to make things easier for the help icons in the admin, use this in the class.cptui_admin_ui.php

public function get_help( $help_text = '' ) {
	return '<a href="#" title="' . esc_attr( $help_text ) . '" class="cptui-help dashicons-before dashicons-editor-help" title="' . esc_attr( $help_text ) . '"></a>';
}

In cptui.css, I changed the styles like this:

.cptui-help {
	color: #424242;
  	opacity: 0.5;
	text-decoration: none;
	width: 16px;
	margin-left: 4px;
}
.cptui-help:hover {
	color: #0074a2;
	opacity: 1;
}
.cptui-help:focus {
	box-shadow: none;
}

Then to make a nice CPTUI menu icon using base64, I used this in custom-post-type-ui.php

function cptui_plugin_menu() {
	add_menu_page( __( 'Custom Post Types', 'cpt-plugin' ), __( 'CPT UI', 'cpt-plugin' ), 'manage_options', 'cptui_main_menu', 'cptui_settings', 'data:image/svg+xml;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAABC9pVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuNi1jMDE0IDc5LjE1Njc5NywgMjAxNC8wOC8yMC0wOTo1MzowMiAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wUmlnaHRzPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvcmlnaHRzLyIgeG1sbnM6eG1wTU09Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9tbS8iIHhtbG5zOnN0UmVmPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvc1R5cGUvUmVzb3VyY2VSZWYjIiB4bWxuczp4bXA9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC8iIHhtbG5zOmRjPSJodHRwOi8vcHVybC5vcmcvZGMvZWxlbWVudHMvMS4xLyIgeG1wUmlnaHRzOk1hcmtlZD0iVHJ1ZSIgeG1wTU06RG9jdW1lbnRJRD0ieG1wLmRpZDo5NkE3NTc5MUJCOTIxMUU0QUVENDlFMUYwOEMyRDgwQyIgeG1wTU06SW5zdGFuY2VJRD0ieG1wLmlpZDo5NkE3NTc5MEJCOTIxMUU0QUVENDlFMUYwOEMyRDgwQyIgeG1wOkNyZWF0b3JUb29sPSJBZG9iZSBQaG90b3Nob3AgQ0MgMjAxNCAoV2luZG93cykiPiA8eG1wTU06RGVyaXZlZEZyb20gc3RSZWY6aW5zdGFuY2VJRD0ieG1wLmRpZDo5NjMzOTU2ODgyMjhFMDExOTg5Q0MwQTFBRDAyQjVDMiIgc3RSZWY6ZG9jdW1lbnRJRD0ieG1wLmRpZDo5NjMzOTU2ODgyMjhFMDExOTg5Q0MwQTFBRDAyQjVDMiIvPiA8ZGM6cmlnaHRzPiA8cmRmOkFsdD4gPHJkZjpsaSB4bWw6bGFuZz0ieC1kZWZhdWx0Ij5DcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uIE5vbi1Db21tZXJjaWFsIE5vIERlcml2YXRpdmVzPC9yZGY6bGk+IDwvcmRmOkFsdD4gPC9kYzpyaWdodHM+IDwvcmRmOkRlc2NyaXB0aW9uPiA8L3JkZjpSREY+IDwveDp4bXBtZXRhPiA8P3hwYWNrZXQgZW5kPSJyIj8+hXhu9wAAAjdJREFUeNrcWYFtwjAQBNQB0g3oBukEDRPUnYCwQRmhE8AGhgnKBh0h2YBuQDZIbclI6GXH7/c7cfrSCxEcuHv+7x3/su/7xZxttZi5/XsChfJP5Y3ynskFKwNdAw4Xym89r9UDv0dy1wd1z2/s4F0ERGbgC+WN8iuGQJFZ2tzB303ANbCIa1O4XLZTfiLeq3H8KC8frr3BRU/g/dbzpRflZ+Wd8ta8pjAbeG2VT4VGL0JE2kArXClUeCJ/GqEvuSL/aGtKJz5nAv5oUtdKYCifuwzAa+Bf8OIS7EZdW9PnCQoWBnADox+SQhjwtQcEFby2vQ18iAr5lEOadboJlkxqczcZspWgEJBgLYYEFnwDZZObgHSsHyKBBY/6N2MISEL0sODRjZNK4IAEocGuzT1lAHiJ7dxYGV0CtZEJe0JrJBMl2xQCN+YdK0rvHSYoD/WXhNHfB4DXmfBNrQGZ4KlNBuxYaxcwThUKsYYCPpZAiCT69H5NAR9LgIuEoILnIBBL4hCQOlajyGjMrhLq/WvIGVzKs9FQ/dbrP3I73A0hoY9bfnM8ncaQOHI2Q64awNZEaN6PVgOYf4It78cacEASG668HyOFUlhUClUTg69iU6hYZGpYAtuJcb5jZ2Q5nE5DL4eGLrCIG89+Zqz5QPUQ+aGhSwsJ6JHqYUZj4j0koJlecy5a0GdeVpaLu5lEX+PsVo48380A/MWmQqkn9RzPz2LoZM7WwGrTB8oJI94a9TtB5fsTYABOp6Z0XZr87gAAAABJRU5ErkJggg==' );
}
add_action( 'admin_menu', 'cptui_plugin_menu' );

Added over at https://github.com/WebDevStudios/custom-post-type-ui/issues/241

I built a site using your awesome plugin. I used the same custom post type structure, but just one CPT was taking you to the home page when you selected any of it’s links. I changed the rewrite option to ‘false’ and it worked but broke some other CPT. One I can’t get to work right. Changing the rewrite to ‘true’ goes to a white page and ‘false’ goes to a 404. The site is ergonarmor.com/datasheets. There are four groups here with a dropdown menu. The Corrosion Engineering group is not working. I desperately need some help.

I updated my plugin with the test version above, but I am still having the same problem.

Hi tipsystudio,

The only one I could get to go to anything other than expected post type post data was the last one, “Corrosion engineering”. Empty white pages typically indicate some sort of php error, which shouldn’t be getting triggered by our plugin on the frontend by any means. For that one, I suggest turning on WP_DEBUG to see what’s going on with that, and it’ll hopefully point you to the right spot for what’s causing that.

I didn’t run into any 404 errors, so not sure if things resolved themselves or if you simply reverted to a previous working.

Michael, how do i publish a new branch in github? Do i need to have permissions from you?

You’ll want to clone the repo to your own account, make any changes on whatever branch you want, and then do a PR on our repo for it.

Must be doing something wrong. Permission denied is my error.