Inline CSS back as an option

  • Resolved Solinx

    (@solinx)


    11 years, 4 months ago

    Hi Greg,

    In version 1.3.1 you changed the way that the dynamic CSS is loaded. Unfortunately I cannot say this was a clear improvement over the old method.

    Loading the WP core for a second time on every page, just to get a few lines of css, is not exactly an efficient solution. Also, simply killing off WP at the init hook may cause issues with other plugins and themes.

    Could you bring back the old method of using inline CSS, at least as an option?

    Regards,
    Wouter van Dam

    https://www.ads-software.com/plugins/siteorigin-panels/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author SiteOrigin

    (@gpriday)

    I’d like to switch over to some sort of hybrid solution in a future update. I’m not going to lie, dynamically loading is causing some issues, but the old method did have it’s own set of problems. The most obvious of which was incompatibility with multisite.

    You’re 100% right though, there should be an option to have CSS inline. Added this to my issue tracker – I’ll try get it up and running in the next update. Thanks for the suggestion Wouter!

    Thread Starter Solinx

    (@solinx)

    Thanks, that will be much appreciated!

    Before posting I tried to think of alternative solutions, but all of them probably involve quite a bit of time.

    The one I favor involves creating an actual css file per page that uses the PageBuilder, to be generated when you save the PageBuilder page. You can avoid generating a ton of files by generating a hash for each css file based on contents. You could then use that hash as filename and store the hash as a meta field of the page.

    This solution would be efficient for visitors, and allow you to use the regular enqueue system as it is meant to be used, but I expect it will involve a bit more work than just putting back the old solution as an option.

    Cheers,
    Wouter

    Thread Starter Solinx

    (@solinx)

    Hi Greg,

    Thanks for including this already!

    Regards,
    Wouter

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Inline CSS back as an option’ is closed to new replies.