Intended incompatibility with WPML causes disfunction

  • Resolved jan.mazanek

    (@janmazanek)


    5 years, 9 months ago

    Frederick,

    I do understand, that you wish to monetize W3TC development + websites with WPML are likely to pay for W3TC Pro…

    …And therefore you decided to implement fix https://wpml.org/errata/w3tc-is-not-minifying-files/ to only PRO users in Extension_Wpml_Plugin_Admin and Extension_Wpml_Plugin …

    …instead of better fixing the source of problem in Util_Environment.php function home_url_regexp() or directly in Minify_Plugin.php functions remove_scripts() and remove_styles()

    BUT do you know, that this way of forcing W3TC users to buy PRO versions not only sucks, but also makes their page worse? Because:
    1) configured minified styles and scripts are included twice: originals + minified version.
    2) Including twice some JavaScript may result in malfunctionality, like imediate closing of mobile navigation in Avada Theme.

    Please, consider release of this fix to all W3TC users or at least make some effort not to include JavaScript+Styles twice, when WPML is active and https://wpml.org/errata/w3tc-is-not-minifying-files/ is not implemented otherwise.

    I do not feel good about W3TC after this experience at this moment. Especially I do worry to update W3TC, because this will cause the need to reimplement changes in Util_Environment.php…

    …But you made a good job with W3TC and I hope you will decide to make it work acceptable with WPML even for none-pro users… please…

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter jan.mazanek

    (@janmazanek)

    2 extra points about W3TC and .htaccess:

    1) related: please make sure, that RewriteBase doesn’t include pseudo-directory used by WPML for languages

    2) unrelated: please do not include in .htaccess line with incorrect value “”:
    Header set Referrer-Policy “”

    This might be probably removed or replaced with:
    Header set Referrer-Policy “no-referrer-when-downgrade”

    Plugin Contributor Marko Vasiljevic

    (@vmarko)

    Hello @janmazanek,

    Since the extension was created WPML made numerous optimizations and in the future, we will consider writing the supported versions of dependencies e.g. plugins for free or premium extensions.

    As for the Referrer policy, this was fixed in 0.9.7.2 version Default – Not set

    Thread Starter jan.mazanek

    (@janmazanek)

    Hello @vmarko ,

    how relevant is what you wrote?

    W3TC extension Extension_Wpml_Plugin.php contains the needed code, but it is intentionaly executed only for your PRO users:
    public function run() {
    if ( Util_Environment::is_w3tc_pro( $this->_config ) ) {
    add_filter( ‘w3tc_url_to_docroot_filename’,
    array( $this, ‘w3tc_url_to_docroot_filename’ ) );
    }
    }

    This code means, that you know, that it is needed to run this to work with WPML, but you do run this only if installations is PRO.

    Or is there some bug that causes, that for PRO users you execute this needed code, but it still doesn’t work even for PRO users?

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Intended incompatibility with WPML causes disfunction’ is closed to new replies.