invalid html markup

  • Resolved yezzz

    (@yezzz)


    9 years, 3 months ago

    When testing my site for errors I found out that CJT wraps its shortcode content in a span for identification.

    I don’t know if/why it’s needed in the final output, but when that content contains html such as a div, this creates invalid html markup, as div’s should not be inside spans.

    https://www.w3.org/TR/html-markup/span.html#span-context

    While browsers seem to handle it just fine, it can have a negative impact on SEO, which is undesirable for me. If not needed I hope for an option to turn it off, or otherwise a better approach can be found. Eg. immediately close the span, then open & close at the end of the code block. Or use div’s, or html comments, or …

    This is a fantastic plugin. I hope it will be updated and patched, and I’ll consider donating or buying the dev version.

    https://www.ads-software.com/plugins/css-javascript-toolbox/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author wipeoutmedia

    (@wipeoutmedia)

    Hi yezzz,

    Thanks very much for taking the time to write this valuable feedback.
    I will certainly talk to my colleague about this and see if we can work out a solution.

    Enjoy your day!

    Regards,
    Damian

    Thread Starter yezzz

    (@yezzz)

    You’re welcome. Hope you’ll find a good alternative.

    Hello yezzz,

    I’m the main developer for this Plugin and I just saw your message.

    You’re right on what you said.

    The container element there is because we’re providing PHP Framework from which you can reach Block Shortcode HTML from JavaScript, here is an example of CJT Date Picker Package code

    <script type="text/javascript">
    <?php /* Dynamically load Theme */ $cb->fw()->template()->useTheme($cb->params()->get('theme')) ; ?>
    // Initialize Date Picker jQuery Plugin.
    window.addEventListener('load', function() {
            jQuery("#<?php echo $cb->containerElementId() ?> input").datepicker(<?php echo $cb->params()->json('theme'); ?>);
        }
    );
</script>

    Note $cb->containerElementId() is returning the SPAN element id

    There is one still knows about this Framework as its not documented yet

    Regards the TAG I will consider this in the next release. We will use DIV tag instead.

    Thanks,
    AHMeD

    Thread Starter yezzz

    (@yezzz)

    Thanks for the feedback and consideration. Div tag would be great, just make sure no css rule picks it up.

    Off-topic: I went through the docs on your website a while ago, and saw it needs updating here and there. Also there was some bad english that needs improvement. Just my 2 cents.

    Have a great day folks!

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘invalid html markup’ is closed to new replies.