is_home() retunrs true for wp_signup.php

  • When addressing file like:
    wp_activate.php
    wp_signup.php

    the function is_home() and therefor is_front_page() returns true.
    Although this is clearly not the case.

    Is this a BUG?

    The problem starts here:
    wp-includes/query.php:1594

    if ( !( $this->is_singular || $this->is_archive || $this->is_search || $this->is_feed || $this->is_trackback || $this->is_404 || $this->is_admin || $this->is_comments_popup || $this->is_robots ) )
			$this->is_home = true;

Viewing 14 replies - 1 through 14 (of 14 total)
  • Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    It’s running an ‘If NOT any of these… THEN treat as is_home.’ Why do you think it’s a bug? What isn’t happening that you expect to happen?

    Thread Starter Koff

    (@orenkolker)

    I met this issue when trying to make wp_signup.php to look like inner page.

    It took some time to get to that because is_home() is true, the body class includes home and therefore looks like home while I expected it to look like inner page.

    The other problem I see with this is that by the codex:

    This Conditional Tag checks if the main page is being displayed

    And one may use this in a plugin thinking he is hacking the main page, while hacking other pages as well.

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    Ah, okay ?? The signup page is intended to act as the outer page on a multisite, since you’re signing up as a part of the network

    Read https://wpmututorials.com/plugins/style-your-signup-page though…

    Are you trying to style signups per site, or just for the network?

    (Also moving this to MultiSite for better localized traction)

    Thread Starter Koff

    (@orenkolker)

    Thanks,

    I encountered this with MultiSite signup.
    And this Almost solve network signup, Its till needs a tweak for RTL.
    And There comes the same problem for wp_activate.php And maybe some more ( I didnt check)

    This dose’t look like the “right” solution to me.

    What about plugins that uses is_home() or is_front_page() ?

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    I get that it’s multisite signup, I’m asking if you’re trying to style the pages for signups per SITE or for the network as a whole ??

    Thread Starter Koff

    (@orenkolker)

    network

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    By default, those pages will grab the design from your main site. Is THAT theme using RTL?

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    By default, those pages will grab the design from your main site. Is THAT theme using RTL?

    Thread Starter Koff

    (@orenkolker)

    Design from the main sites homepage as in oppose to inner page.

    And yes RTL is used.

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    What do you mean by ‘inner page’? The main site is whatever theme you have at domain.com – Inner pages (i.e. pages from your main site) are still using that theme. SUB SITES may not be.

    Thread Starter Koff

    (@orenkolker)

    I mean inner page of the main site. (index.php)
    as in oppose to homepage of the main site (home.php)

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    You’re talking theme file names and not front end post/page names.

    https://codex.www.ads-software.com/images/1/18/Template_Hierarchy.png

    Again, the INNER page of your site is still a part of the THEME you’re using for that site. That does NOT change, unless you did something to make your home.php or front-page.php vastly different.

    Thread Starter Koff

    (@orenkolker)

    Yeap.

    Something like different background.

    The header is Dark blue.
    And The page is white

    while the homepage is Dark blue.

    Then the signup page is surprisingly Dark blue because is_home = true

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    ?????? Advisor and Activist

    Okay so Read https://wpmututorials.com/plugins/style-your-signup-page

    You can you that to restyle it.

Viewing 14 replies - 1 through 14 (of 14 total)
  • The topic ‘is_home() retunrs true for wp_signup.php’ is closed to new replies.

Tags