• Resolved peopleinside

    (@peopleinside)


    Hi, thank you again for this nice and useful plugin!
    I found two issues and I have a feature request.

    Issue one:
    – There is a conflict with the plugin External Links in New Window / New Tab. If your extension and that plugin is active, links that should open in a new Window will open in the new Window but also the current Window where user clicked the link is redirected to the link… so user will have two tab opened and two tab redirected to the clicked link. Can you resolve this issue?

    – If in the website menu I add a page that have subpages: for example in the menu I add the item “utility” and under the utility page I put other subpages and in your plugin I ask to show the loader as soon a link is clicked, the loader will be not showed for the page utility. Will be showed in all other link or page or subpages but not utility. Can be this resolved? You can see a GIF video here (need some time to load). When I click on the page with subpage the loader is not showed immediately as for other links.

    Feature request: When a custom logo is selected for the loading the logo size is very small. Can you add the possibility to choose the loading custom logo size?

    Thank you!

Viewing 15 replies - 1 through 15 (of 15 total)
  • Plugin Author codepeople

    (@codepeople)

    Hello @peopleinside,

    Both issues are caused by the same plugin configuration. If you tick the checkbox to display the loading screen as soon as possible, the plugin must intercept every link in the page to display the loading screen. However, if these links have events associated with the browser’s navigation, they could be affected. So, the solution would be to untick the “Show loading screen when clicking on the link” checkbox.

    Regarding the logo size, the current plugin version allows you to modify it. Please enter the style definition below through the “Include an ad, or your own block of code” attribute in the plugin settings page (or via the menu option “Appearance > Customize > Additional CSS”).

    
    <style>
    .lp-logo-wrapper{width:300px !important;}
    #lp_ls_img{width:300px !important; height:300px !important;}
    </style>

    Best regards.

    Thread Starter peopleinside

    (@peopleinside)

    Hi, thank you for answering and to keep this plugin updated!
    You suggested to disable the option “Show loading screen when clicking on the link” but I need this to be active and working on all links, disable that is not the solution. In some other website I use a different loading plugin that has not that issue so, even with External Links in New Window / New Tab enabled and the loading screen showed as soon a link is clicked.. the two issues I’m reporting here are not present. The issue happen only with your plugin and with that external link other plugin.

    I suppose, from your reply, will be not a fix for that. It’s ok, I tried to report the issue hoping in a fix but I can read at the moment there is no solution. I can try to report the issue to the External Links in New Window / New Tab but the issue is present also with the other plugin External Links – nofollow, noopener & new window from the same developer. With that second extension issues are just one no more two. The issue with this second plugin will be just the loading screen not showed in a link that has subpages in the WordPress menu.. so seems it’s an issue from your plugin.

    I had to test in a fresh WordPress install if that issue still be present about not showing the loading as soon that specific page is clicked.

    I will try to request a fix on the other external link extension for the issue of the clicked link redirected in the current and new tab.

    • This reply was modified 1 year, 3 months ago by peopleinside.
    Thread Starter peopleinside

    (@peopleinside)

    I tested the function “Show loading screen when clicking on the link” on a page with subpages without any external link plugin active. The issue still be present so seems to be not caused by that plugin but seems to be an issue present on the loading screen plugin.

    Plugin Author codepeople

    (@codepeople)

    Hello @peopleinside

    Could you please install the latest plugin update (released just now) and purge the website and browser caches?

    Please let me know if the issue persists.

    Best regards.

    Thread Starter peopleinside

    (@peopleinside)

    Hi, thanks for the reply.
    The new version is the version 1.1.1? Is the latest version I see even if say is old about two weeks. I see the dev note of the version 1.1.1 is “Accept style and link tags in the Ads block”

    I cleared the cache but I still the the same two issue I reported.

    Plugin Author codepeople

    (@codepeople)

    Hello @peopleinside

    Not really, the latest version is the 1.1.2

    https://www.ads-software.com/plugins/loading-page/

    I see that WordPress updated it only some seconds ago.

    Best regards.

    Thread Starter peopleinside

    (@peopleinside)

    Oh I see. Let me try again ^_^
    One issue resolved, now the link opens correctly in a new tab without reload also the current tab.

    Still see the issue that if a page has subpages and that page is clicked, the loading screen is not showed as soon the link is pressed.

    Anyway much better with this last fix resolving the link in new tab issue. Thank you.

    Plugin Author codepeople

    (@codepeople)

    Hello @peopleinside

    Could you please provide the URL to your website to check the structure of your nav-menu links?

    Best regards.

    Thread Starter peopleinside

    (@peopleinside)

    Sure.
    [Link]

    Thread Starter peopleinside

    (@peopleinside)

    Nother example can be seen here with a lot of pages with subpages so the issue is more present: https://www.peopleinside.it

    Plugin Author codepeople

    (@codepeople)

    Hello @peopleinside

    The issue with those links is that the website code captures the onmouse event, processes it, and does not propagate the onclick event used by our plugin.

    For testing, please follow the steps below:

    1. Open the “/wp-content/plugins/loading-page/js/links.min.js” file with the text editor of your choice.
    2.  Go to the piece of code:
    c(document).on("click","a",

    and edit it as follows:

    c(document).on("mousedown","a",

    3. Finally, purge your website and browser caches before testing again.

    I replaced the click event with the mousedown.

    Best regards.

    Thread Starter peopleinside

    (@peopleinside)

    Great! It’s working, thank you! This will be included also in future version? I will not loose the change in next update? Thanks again! Happy to see that fix ??

    Plugin Author codepeople

    (@codepeople)

    Hello @peopleinside

    No, sorry, we can’t include it in the plugin distribution because this implementation has a problem. Go to your page, click on the link, and then move the mouse off the link before releasing the click.

    Since the loading screen is displayed on the mousedown, but you do not complete the click action, the plugin will display the loading screen, but the browser will not navigate.

    In my opinion, I prefer to display the loading screen with the click event. Even if some links are intercepted by third-party plugins or the theme, and the plugin cannot display the loading screen until the browser starts loading the new page.

    Best regards.

    Thread Starter peopleinside

    (@peopleinside)

    @codepeople oh I see.. this code edit is not very good.
    If you visit now https://www.peopleinside.it you will see.. I restored another plugin that does the right job.. so maybe a solution exist but I don’t know what is.

    I’m now reverting back to using another loading plugin and all works.. is only more slow to loading page and that was why I prefer your plugin. Looks your plugin is also more updated but miss loading on some page is something little bit sad ??

    Plugin Author codepeople

    (@codepeople)

    Hello @peopleinside

    Unfortunately, we cannot control what other plugins do.

    Best regards.

Viewing 15 replies - 1 through 15 (of 15 total)
  • The topic ‘Issues and improvment request’ is closed to new replies.