Issues testing in 4.30; activity stream, BP notifications

Awesome.

Regarding the email part, we stick with wp_mail() at the present time, so it’s up to that to do its thing.

“I approved a user in your plugin, but the user was still pending in WordPress.”

I assume you mean like in BuddyPress core’s moderation tools as well?

I can confirm that the most recent zip download has corrected the blank notification issue. Thank you.

However, I still have the ‘unapproved new user posted to activity stream’ issue. With the ‘new member’ post still happening BOTH upon initial registration (pre-approval) and again upon admin approval.

I was hoping you could replicate. If you can’t reproduce the issue, please confirm. I have loads of BP plugins on this test site, so maybe it’s a conflict there. I’ll continue to test.

Thanks again for your work here.

The notification part was my bigger focus, since I had multiple people reporting that one. Will continue with the activity stream part. It is possible that the value I’m trying to null out is getting re-set by something else. Will see if I can recreate with a bare install.

Can you provide the BP plugins you’re using Mitch?

Totally understand the focus prioritization.

Sure. Don’t laugh, I got a few:

Currently active –

Bowe Codes by imath – 2.1
bp-custom-mac by – 0.5 20161201
BuddyExtender by Pluginize from WebDevStudios – 1.0.1
BuddyPress Activity Plus by WPMU DEV – 1.6.4
Link Page to Groups by BuddyDev – 1.0.2
SuitePlugins – Advanced XProfile Fields for BuddyPress by SuitePlugins – 1.0.3
bbPress by The bbPress Community – 2.5.11
BuddyPress Activity ShortCode by BuddyDev – 1.0.8
BP Group Organizer by David Dean – 1.0.8
BuddyPress Moderation by Francesco Laffi – 0.1.7
BP Profile Search by Andrea Tarantini – 4.6.3
BP Reactions by imath – 1.0.1
BP Registration Options by Pluginize – 4.3.0
BuddyPress Cover Photo by SeventhQueen – 1.5.1
BuddyPress Group Email Subscription by Deryk Wenaus, boonebgorges, r-a-y – 3.7.0
BuddyPress Members Import by Soumi Das – 4.3
BuddyPress Profile Tabs by Jacob Schweitzer – 1.6.1
BuddyPress Xprofile Custom Fields Type by donmik – 2.6
BuddyPress by The BuddyPress Community – 2.7.3
Invite Anyone by Boone Gorges – 1.3.13
Mass Messaging in BuddyPress by Eliott Robson – 2.2.0
MediaPress by BuddyDev – 1.0.7

There are another 27 BP plugins in various stages of testing on the site, but that are inactive right now, so they should not affect this issue.

Lastly, I have two MU plugins, a) Plugin Organizer and b) S2Member that are used to a) eliminate plugin conflicts and reduce load and b) to manage levels/content access.

Hope this helps.

Have a great day.

Hi Michael

“I approved a user in your plugin, but the user was still pending in WordPress.”
I assume you mean like in BuddyPress core’s moderation tools as well?

Not sure what you mean with core moderation – user was pending, because the email with activation link was “late” for some reason. I posted before I received the activation email, so you can ignore that one.

Mails:
I wonder why the email format differ, because I use WP Better Emails :

“WP Better Emails wraps every “text/plain” email sent with the WordPress function wp_mail().”

I see ‘Membership approved’ mail as plain text (not so pretty)
“Pending membership” as HTML ? (prettier!)

– are you using the same function for both?

Thanks again for your work on this – let me know if you need me to test something.

Enjoy the holidays ??

Lars

• This reply was modified 8 years, 2 months ago by Lars Henriksen.

All the places I use wp_mail, which is the only thing I use for sending emails in the plugin:

https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/admin.php#L285-L305

https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/core.php#L561-L565

https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/core.php#L583-L594

https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/admin.php#L1005-L1016

It’s never really worked all that well, to be honest, and like I mentioned earlier, I’m planning to migrate to BP’s email setup and be done with it ??

Not managing to recreate the duplicate activity posting still. Best I could do is install as many of the plugins as I could manage to find, and activate them all. However, even at that point, there was no activity posting until I actually approved the user.

Hmmm. Interesting. I’m going to take a step all the way back (theme and plugins) and see what I can figure out. I’ll bet it’s something in bp-custom. There’s a lot in there. ??

It’s just strange that I didn’t notice the double post part until I added 4.30.

Thanks for looking at it in detail. I’ll post any updates from testing as I have them.

Merry Christmas and Happy Holidays!