Issues with iframe size

  • Anonymous User 16041054

    (@anonymized-16041054)


    6 years, 8 months ago

    I’m in the process of testing this plugin in a clean WordPress install with just WooCommerce using the Storefront theme and notice some issues regarding the iframe size.

    WordPress 4.9.4
    WooCommerce 3.3.4
    WooCommerce MyParcel 2.4.8

    1) The iframe body tag margin is not reset.
    By default browsers apply margin to the body tag (8px in case of IE and Chrome). This causes the content in the iframe to not be horizontally aligned correct with other elements on the page.

    2) The iframe height is not correctly calculated.
    The iframe height is calculated in javascript using document.body.scrollHeight however this does not include margins. As margins are not reset (see previous point) the calculated height is off by 16px which causes a scrollbar to appear in Chrome.

    3) Then switching between delivery options “Thuis of op het werk bezorgd” and “Ophalen bij een PostNL locatie” a scrollbar can be visible during animation when the content you switch to is larger than the content you come from. This can easily be the case when several options have been enabled like morning and evening delivery.

    4) The iframe is not resized when choosing a different pickup point causing a double scrollbar to appear. Now when selecting a pickup point the frame is suddenly resized to the size it should have had in the previous step and also stays at this size which in most cases is too high for what it actually needs. I noticed the list of pickup points is written to the DOM when you want to select a new pickup point but it is not removed or made invisible when you actually select one so its height is included in the iframe height calculation even though it is “off screen”.

    As it looks like all files responsible for the iframe resizing behavior are part of the plugin these should be fixable and improve the customer experience. If any of these issue are caused by other means please let me know so I can fix them from my end.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Richard Perdaan

    (@richardperdaan)

    Thank you René Kamp for notice some issues regarding the iframe.

    Currently we are working on a new MyParcel checkout, where these problems must be solved.

    Because of the problems, we have chosen that the shipping methods will not be made in an iframe. Another point is that he must be user-friendly, on all the devices.

    For now I have no solution, but the new checkout will be processed in a new version.

    Thread Starter Anonymous User 16041054

    (@anonymized-16041054)

    Hello Richard,

    I can just patch these issues for myself for the time being. Good to hear you are planning to get rid of the iframe as it’s a bit weird already to see an iframe with shadow DOM inside which kind of eliminates the need for an iframe anyway. Do you have any indication when this new version will be ready?

    Plugin Author Richard Perdaan

    (@richardperdaan)

    Hello René

    In the MyParcel road map is this planned as the next point. Because the new checkout must be extensively tested, it is difficult to say when it is finished.

    When the new checkout is available, I will leave a message here.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Issues with iframe size’ is closed to new replies.