• Resolved fidoboy

    (@fidoboy)


    This plugin is incompatible with the Slider Revolution. It should be fixed to avoid breaking the pieces of code generated by that WordPress plugin. There is any plan to fix it on future releases?

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Tim Eckel

    (@teckel)

    When there’s an incompatibility, the issue is always which piece is at fault. Sometimes, neither are at fault as well.

    In any case, I would bet that Minify HTML will work just find with Slider Revolution if you set the settings to be compatible. This is exactly why there’s settings for Minify HTML, so you can turn on/off settings for compatibility reasons.

    In the FAQ section for Minify HTML, it describes the following:

    Are there any settings for Minify HTML?

    Yes. Under the Settings menu in the admin console there’s a Minify HTML menu item which allows you to modify Minify HTML settings.

    Set all settings to “No” and then see if everything works. If so, try turning on each setting till Slider Revolution fails. Then you’ll know what’s causing Slider Revolution to fail. Just leave that setting off so Slider Revolution doesn’t fail. Once you know what’s causing Slider Revolution to fail, you could contact them and let them know how they could fix their plugin to be compatible with minification.

    Thread Starter fidoboy

    (@fidoboy)

    Well the problem is that your plugin is removing spaces into the inline javascripts. And even if I disable the option to minify inline javascript it’s already removing the spaces. So there is a bug in your plugin.

    Even when the option to minify inline javascript is activated, it shouldn’t be removing that spaces. But it’s worst when it’s removing also when option is set to NO.

    For example when there is a line with:

    <script>
    var revapi = 3;
    </script>

    after using this plugin is being converted into:

    <script>
    varrevapi=3;
    </script>
    Plugin Author Tim Eckel

    (@teckel)

    Turning off the minify inline JavaScript option would no longer minify inline JavaScript, resolving your issue.

    Thread Starter fidoboy

    (@fidoboy)

    That’s not right. I’ve verified it. I disabled the minify inline javascript and it keeps removing spaces as I’ve said in my previous message. Something is causing that the plugin functions are not considering the javascript code as javascript code, and it happens when the slider revolution plugin is present on that page, so there is a bug. If your plugin were working well, it would not fail to minify javascript code when the option is disabled, that is, it would not be affected by the presence of a certain code on the page. If someone disables the “minify inline javascript” option into the plugin settings, then he expects that it works that way, that is, NOT MINIFIYING THE JAVASCRIPT CODE IN ANY CASE. You can verify it to see how it fails when there is a certain code into the page, like for example, the one being created by slider revolution. Just test it by yourself.

    I’m using PHP 8.0 if it helps in order to reproduce the issue.

    There is a bug in your plugin. There is no place to the doubt.

    Plugin Author Tim Eckel

    (@teckel)

    Have you turned off every other option as well? I’ve never heard of a situation where turning off every option didn’t resolve the problem.

    But, if even after you turn off every option you’re still having a problem, there must me something wrong with the slider revolution plugin. You’ll need to either remove slider revolution or minify html. I’m not using slider revolution so I have no way of diagnosing why that plugin isn’t working for you.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘It doesn’t works with Slider Revolution plugin’ is closed to new replies.