Javascript dependencies for woo scripts

I just saw broken dependencies for woocommerce_settings (WooCommerce does not use ‘chosen’ any more, for versions: 2.6 and newer – https://github.com/woocommerce/woocommerce/blob/master/includes/admin/class-wc-admin-settings.php#L139). You can see it when open QM (Query monitor). It depends on woo version. Possible fix is:

            $woocommerce_settings_deps = array( 'jquery', 'jquery-ui-datepicker', 'jquery-ui-sortable', 'iris' );
            if( version_compare( WC()->version, '2.6', '>=' ) ) {
                // WooCommerce > 2.6
                $woocommerce_settings_deps[] = 'select2';
            }            
            else {
                // WooCommerce < 2.6
                $woocommerce_settings_deps[] = 'jquery-ui-dialog';
                $woocommerce_settings_deps[] = 'chosen';
            }
            wp_enqueue_script( 'woocommerce_settings', WC()->plugin_url() . '/assets/js/admin/settings.min.js', $woocommerce_settings_deps, WC()->version, true );

At this moment, I tested it on Woo 2.6 and Woo 3.0. It should work on older versions (I don’t have them on my test server and I can’t test).

Sasa

• This topic was modified 7 years, 9 months ago by Sa?a.