Javascript within php echo do_shortcode

(@thomstark)

That’s because your PHP is full of syntax errors.

<?php

$content = '<div id="contentclick6964"></div>
<script type="text/javascript">
	(function() {
		var data =
			{
				pub_id: "2818",
				w_id: "6964",
				pw: "21b55185dff4f8",
				cbust: (new Date()).getTime()
			};
		if (typeof widgetCheck6964 === "undefined")
		{
			var u="";
			for(var key in data){u+=key+"="+data[key]+"&"}
			u=u.substring(0,u.length-1);
			var a = document.createElement("script");
			a.type= "text/javascript";
			a.src = "https://api.contentclick.co.uk/pub_serve.php?" + u;
			a.async = true;
			document.getElementById("contentclick6964").appendChild(a);
			window.widgetCheck6964 = "set";
		}
	})();
</script>';
echo do_shortcode('[showto browser="desktop"]'.$content.'[/showto]'); 

?>

Thread Starter

(@jerome330)

That’s great! Thanks for fixing this and getting back to me quickly. I’m not very good with PHP as you can tell.

So is it possible to use this PHP snippet multiple times with different javascript ad tags on the same custom page template?

Thanks again!

Plugin Author

(@thomstark)

Use a different variable for each of them. $content for one. $stuff for two. $junk for three. Whatever you want.

Plugin Author

(@thomstark)

Note that the $content variable is wrapped in single quotes. So all the quotes in your js need to be double quotes, or escaped single quotes, like this: \’stuff\’

Thread Starter

(@jerome330)

Does this look right?

<?php

$adtag = ‘<div id=”contentclick11882″></div>
<script type=”text/javascript”>
(function() {
var data =
{
pub_id: “2818”,w_id: “11882”,pw: “e8b49fec695569”, cbust: (new Date()).getTime()
};
if (typeof widgetCheck11882 === ‘undefined’) {
var u=””;
for(var key in data){u+=key+”=”+data[key]+”&”}
u=u.substring(0,u.length-1);
var a = document.createElement(“script”);
a.type= ‘text/javascript’;
a.src = “https://api.contentclick.co.uk/pub_serve.php?” + u;
a.async = true;
document.getElementById(“contentclick11882”).appendChild(a);
window.widgetCheck11882 = “set”;
}
})();
</script>’;
echo do_shortcode(‘[showto browser=”tablet”]’.$adtag.'[/showto]’);

Thread Starter

(@jerome330)

Never mind, I think I figured it out. I was missing the double quotes on a.type and undefined.

Plugin Author

(@thomstark)

That’s right. Otherwise looks good.

Thread Starter

(@jerome330)

Great! Thanks for all your help with this! Awesome plugin BTW. This has saved me a lot of time and frustration. I’m going to have to check out some of your films as well as I use to be a editor and sound guy.

Thanks again!

Plugin Author

(@thomstark)

Not a problem. Have fun and enjoy.

Plugin Author

(@thomstark)

Another way you could do all this of course is pure jquery, based off of the body classes that my plugin creates.

if $('body').hasClass('desktop')
{
 // function here
}
else if $('body').hasClass('tablet')
{
  // function here
}
else if $('body').hasClass('mobile')
{
  // function here
}

Thread Starter

(@jerome330)

Hi, so I’m currently using your plugin on a few of my sites and I am noticing that sometimes they are firing the wrong ad size on Desktop. It seems to be firing mobile ads and tablet ads on Desktop.

I am using the following code below in my custom page templates.

<?php echo do_shortcode(‘[showto browser=”desktop”]<!– BEGIN JS TAG – FC – Desktop – 728×90 – bottom near footer < – DO NOT MODIFY –>
<SCRIPT SRC=”https://ib.adnxs.com/ttj?id=4566612″ TYPE=”text/javascript”></SCRIPT>
<!– END TAG –>[/showto]’); ?>

This seems to be working for the most part minus the misfires? Could it be something else?

Thanks in advance for any help you can give me!

Plugin Author

(@thomstark)

I only see the desktop ad in here. What about the mobile and tablet ads? Where’s the rest of the code?

Thread Starter

(@jerome330)

Below is all of the code from one of my custom page templates:

[excessive and mangled code removed – please use a pastebin see:
https://codex.www.ads-software.com/Forum_Welcome#Posting_Code ]

Plugin Author

(@thomstark)

Your code was removed by WordPress.

Thread Starter

(@jerome330)