jQuery 3.5 support

  • Resolved Tharkon

    (@tharkon)


    3 years, 9 months ago

    I am getting the following error when using the latest jQuery version without jQuery migrate with a Carousel with Preloader enabled.

    Uncaught TypeError: e.indexOf is not a function
    at S.fn.init.S.fn.load (jquery.min.js?ver=3.5.1:2)
    at HTMLDivElement.<anonymous> (preloader.min.js?ver=2.1.16:1)
    at Function.each (jquery.min.js?ver=3.5.1:2)
    at S.fn.init.each (jquery.min.js?ver=3.5.1:2)
    at preloader.min.js?ver=2.1.16:1
    at preloader.min.js?ver=2.1.16:1

    This causes the Carousel to remain hidden and the Preloader to remain visible. If I disable the Preloader in the Carousel there are no errors.
    JQuery migrate is scheduled to be disabled in WordPress on 9 March 2021.

    The page I need help with: [log in to see the link]

Viewing 8 replies - 1 through 8 (of 8 total)

  • I have the same issue

    Plugin Author ShapedPlugin LLC

    (@shapedplugin)

    Hi @ben1390 @tharkon

    Sorry for the delay response!

    Thank you for using our plugin and letting us know the issue to fix and improve the plugin. We have fixed the issue today and released a new version 2.1.17.

    Please update to the latest version and let us know if everything remains fine.

    Have a great day!

    Thank you.

    Hi,

    Are there plans to release an update to the pro version too?

    Many thanks

    Plugin Author ShapedPlugin LLC

    (@shapedplugin)

    Yes, Sure ??

    Thanks

    Thread Starter Tharkon

    (@tharkon)

    Looks like that fixed the issue.

    A related issue however to truly be 100% jQuery 3.5 compatible would require fixing a few things in the Slick library since jQuery.type is deprecated as of 3.3 (https://api.jquery.com/jquery.type/). I would still consider this resolved if you choose not to fix that because it looks like that isn’t your code. I have made the following edits myself on my own website that seem to do the trick.

    On line 2154:
    if( $.type( arguments[0] ) === 'object' ) {
    if( typeof arguments[0] === 'object' && arguments[0] !== null ) {
    On line 2160:
    } else if ( $.type( arguments[0] ) === 'string' ) {
    } else if ( typeof arguments[0] === 'string' ) {
    On line 2166:
    if ( arguments[0] === 'responsive' && $.type( arguments[1] ) === 'array' ) {
    if ( arguments[0] === 'responsive' && Array.isArray(arguments[1] ) ) {
    On line 2196:
    if( $.type( _.options.responsive ) !== 'array' ) {
    if( !Array.isArray(_.options.responsive ) ) {

    @shapedplugin is there any timescale for releasing a new pro version of the plugin?

    Plugin Contributor Md Khalil Uddin

    (@khalilu)

    Hi, @ben1390

    We have noted it in our development roadmap. Hopefully, we’llll release it ASAP. Your patience would be appreciated.

    Have a good day!

    Thank you.

    @tharkon Very helpful!

    But perhaps you forgot one? I changed also:
    On line 1890:
    if ( $.type(responsiveSettings) === 'array' && responsiveSettings.length ) {
    if ( Array.isArray(responsiveSettings) && responsiveSettings.length ) {

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘jQuery 3.5 support’ is closed to new replies.