js error in data-option sortby

  • Resolved Veerle Verbert

    (@littlekitten)


    10 years, 6 months ago

    hello,

    with the latest upgrade our feed broke,
    js console: ‘Uncaught SyntaxError: Unexpected end of input’ in sb-instagram.js

    think there’s a problem with the quotes in the new data-option (new random order feature), thought it should work with the "’s, but it doesn’t..
    changed it (temporarily) instagram-feed.php line 100 to
    ... data-options=\'{"sortby":"'.$atts['sortby'].'"}\' ...

    and the feed is back up & running. could you please take a look at this?

    (very nice plugin, thx a lot!!)

    https://www.ads-software.com/plugins/instagram-feed/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author smashballoon

    (@smashballoon)

    Hey Veerle,

    I’m not able to replicate the issue, but I just updated the plugin and changed the double quotes to escaped single quotes on that attribute as you suggested. If you update to version 1.2.1 then this should be resolved.

    Just out of interest, could you let me know which browser you received that error in?

    John

    Thread Starter Veerle Verbert

    (@littlekitten)

    Hi John, thx a lot!
    upgraded to 1.2.1 & all is well

    i had it in chrome on mac. in the inspector (elements tab) de code highlighting was incorrect on the data-options attribute, now the highlighting shows {“sortby”: “none”} as the value.

    Plugin Author smashballoon

    (@smashballoon)

    Hey Veerle,

    Happy to hear that! I wasn’t able to replicate the issue in Chrome on Windows, so perhaps it’s only related to Chrome for Mac. Nonetheless, glad to hear the update resolved it.

    If you like the plugin then please consider leaving a quick review. It really helps to support the plugin!

    If you have any other issues or questions then just let me know. Have a great weekend!

    John

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘js error in data-option sortby’ is closed to new replies.