JS Inline Comments Causing Error?

well, that would be my first remark; inline comments normally do get removed? isn’t that the case for you?

No it doen’t in my case.

Here’s the culprit file: https://simplymyhair-4a27.kxcdn.com/wp-content/plugins/feed-them-social/admin/js/admin.js?ver=4.7.5 (from plugin Feed Them Social)

And this is the generated file: https://1drv.ms/u/s!AoJO8z-oV8zek8owzrCCPtMP9vYBvg (search for // end of form.submit and you’ll see it breaks the code)

• This reply was modified 7 years, 6 months ago by wooncherk.

But I don’t see a comment in https://simplymyhair-4a27.kxcdn.com/wp-content/plugins/feed-them-social/admin/js/admin.js?ver=4.7.5 @wooncherk ?

Sorry, I had to remove the comments to make it work. The original file is at:

https://simplymyhair-4a27.kxcdn.com/wp-content/plugins/feed-them-social/admin/js/admin.old.js?ver=4.7.5

OK, and when the comments are there, are they all retained after minification, or only the last one?

You can see a copy of the generated file here: https://1drv.ms/u/s!AoJO8z-oV8zek8owzrCCPtMP9vYBvg. Search for these comments:

// end of ajax()

// end of document.ready

// end of form.submit

the weird thing is that in that autoptimized file that piece of code is in fact _not_ minified at all, which explains why those comments are there.

let me try to reproduce that …

Sure. And the plugin in question is Feed Them Social. ??

OK;
1. I can reproduce the specific JS not being optimized, no idea yet why I’m afraid
2. in the upcoming AO2.2 this does not trigger JS errors, as there’s newline after each optimized file

next steps:
1. I’ll look into why that part of the code is not optimized.
2. could you check out AO2.2 to see if this at least stops the resulting JS errors?

frank

oh, as a workaround adding feed-them-social/admin/js/admin.js to the JS optimization exclusions list would obviously also work.