Last update broke forum styles

[codejp3]

FYI, the last update lost my forum styles.

They’re still saved in the DB, but not actually being applied to the frontend anymore.

Reverted back to the last release until this is fixed.

[Robin W]

is that from 5.1.8 to 5.1.9?

[Robin W]

Mine seem to be working

by forum styles, do you mean all, or just those form a particular tab ?

and just styles, or all settings?

[codejp3]

5.1.7 is the last version that actually applies forum styles.

I’m specifically referring to the styles set in the tabs for:
Forum Index Styling
Topic Index Styling
Topic/Reply Display

Maybe more, but those are the core ones.

I reverted back to 5.1.8 first. Styles not applied, Hitting the “save” button on those tabs has no effect.

Reverted back to 5.1.7. Styles not applied. Hitting the “save” button on those tabs works and reapplies styles to the frontend.

Tried to update to 5.1.8 again. Styles not applied, hitting the “save” button on those tabs has no effect.

Tried to update to 5.1.9 again. Styles not applied, hitting the “save” button on those tabs has no effect.

Only 5.1.7 is the last version applying styles for me, and I have to hit the “save” button on those tabs for the values to actually be applied.

Without digging into code, it seems something changed with how values are saved/fetched from the DB.

[Robin W]

I’ve had a look, and cannot see anything in the changes between 5.1.7 and 5.1.8 that would cause this.

I also cannot replicate on my test site

my plugin does css and function changes – I think you are referring to css chnages – yes

if so can you give me a specific item on a specific tab that I can check on my site, it may be that I am not testing the same stuff.

[codejp3]

I wiped all versions of the plugin and started from scratch. 5.1.9 does seem to be applying styles now.

I’m going to chalk this up to an issue on my part due to background sync-ing between my code editor and the site since I’m knee-deep in development of a site right now.

Marking as resolved.

HOWEVER:
Testing this issue led me to find consistent 404 not found errors in my log for both bspstyle.css and bspstyle-quotes.css. Of course they disappear when a user actually hits “save” in the tabs for those files to be generated, but until then, they don’t exist and kick out 404 errors.

I’d suggest either shipping the plugin with empty bspstyle.css and bspstyle-quotes.css so that there’s SOMETHING there to enqueue, or adding a conditional “if file_exists” check before enqueuing those files.

ALSO:
FYI, I still have to manually apply these fixes to 5.1.9:
https://www.ads-software.com/support/topic/classes-bsp-one-half-bsp-one-third-missing/

https://www.ads-software.com/support/topic/reply-button-missing-closing-div/

https://www.ads-software.com/support/topic/uncaught-referenceerror-jquery-is-not-defined-38/

https://www.ads-software.com/support/topic/moderation-tools-issue/

[Robin W]

thanks as always, and yes I’ll get to those as soon as I can – I do really appreciate your help ??

[codejp3]

Would it be helpful for me to post 5.1.9 on github and a new branch with these changes so you can compare code, and download the already modified files directly? Test it out with the bbp topic count plugin first and see if it’s helpful. If so, I’ll do the same thing with this plugin.

[Robin W]

yes please

[codejp3]

I think I narrowed this one down some more.

Custom generated files get removed on plugin update. I’ve found myself having to go into BSP and re-click “save options” just to regenerate custom files after an update.

A minor inconvenience for a single site install. A total pain for multisite installs.

I added a plugin_activation hook that will automatically regenerate custom files any time the plugin is updated, for both single site installs and multisite installs.

This will be included in the update I send you later today.