Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    Hey zitrusblau,

    I think this is a nice idea ?? It should be fairly easy for video and audio, but I do not see an option for auto-modifing of markup for background images. Could you provide the use case(s), where you are using background images, so I can take a look at the markup and check if it is possible to automate that?

    But if possible or not for background iamges: I will include an option to also load the unveilhooks plugin ??

    Regards,
    Florian

    Thread Starter zitrusblau

    (@zitrusblau)

    Thank you for the fast response.

    We’d be fine to manually add the “data-bg” attribute or whatever in markup or use the addClasses option of the plugin in order for background-images to be lazy loaded.

    To be honest, I don’t see any WordPress-related use cases (yet), either. ??

    An option for the unveilhooks plugin sounds awesome, thanks!

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    Okay cool, I will prepare a new version ??

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    Hi zitrusblau,

    would you give the version from the master branch on GitHub a try if it works for you? https://github.com/florianbrinkmann/lazy-loading-responsive-images

    It adds – among other things – an option to load the unveilhooks plugin.

    Thanks in advance! ??
    Florian

    Thread Starter zitrusblau

    (@zitrusblau)

    Great news ??

    Works as expected with “data-bg”-attribute for background images, thank you!

    I just wondered if providing the plugin options solely in the customizer might be too “exclusive” for users that don’t rely or use it very often.

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    ?Works as expected with data-bg-attribute for background images, thank you!?

    Cool, thanks for testing!

    ?I just wondered if providing the plugin options solely in the customizer might be too ?exclusive? for users that don’t rely or use it very often.?

    You would make an own settings page? And what exactly do you mean with ?don’t rely?? ??

    Cheers,
    Florian

    Thread Starter zitrusblau

    (@zitrusblau)

    You would make an own settings page? And what exactly do you mean with ?don’t rely??

    What I mean is that the customizer is not mandatory (yet) to configure settings in WordPress. But an alternative settings page could be a bit overdose here.
    Well, it’s totally up to you how to provide the plugin settings.

    It’s just that the classic way to setup things seems to be a more common approach to me. Nevermind ??

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    The longer I think about it, the more I think that you are right and that the Customizer may not be the right place for the settings of the plugin, because they do not change anything on the visual side of the site (if everything works correctly)… Mhh, I will think about it a little longer, maybe the settings could find a home on the media settings page ??

    Thread Starter zitrusblau

    (@zitrusblau)

    Alright.

    If you add it to the media settings, you’d consider to add a settings “quickaction” link on the plugins screen for the plugin, so that the folks that don’t know how to navigate to it and that suspect it to be in the usual settings submenu will find it.

    A little bit of redundancy is always a good idea here.

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    Yes, that’s a good idea.

    Plugin Author Florian Brinkmann

    (@florianbrinkmann)

    I just released a new version (three, to be specific, because bug fixes…) to the W.org repo, wich contains the new options in the new place ??

    Thread Starter zitrusblau

    (@zitrusblau)

    great, thanks! ??

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘Lazyload background-images, videos etc.’ is closed to new replies.