Little bug when disabling “send” button and uploads success or fails

  • Resolved shamank

    (@shamank)


    5 years, 9 months ago

    Hey! First of all, awesome work! I’ve already wrote a 5 star review because your work deserves it.

    I wanted to let you know about something I’m experiencing when uploading multiple files (I tested it also in your demo page and it also occurs).
    I’ve seen you added functionality to disable sending button while uploading a file, which is great and works as expected if you are dealing with just a single file. However, if you are uploading, let’s say, a 20 MB file and a 10 KB file at the same time, when 10 KB file upload finishes (or fails for any reason) it will enable sending button even if there are other files still uploading (like the one of 20 MB).

    Would it be possible to check that all file uploads are done before enabling the sending button?

    Thank you!

    • This topic was modified 5 years, 9 months ago by shamank.
    • This topic was modified 5 years, 9 months ago by shamank.
Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Glen Don Mongaya

    (@glenwpcoder)

    Hello shamank,

    Give me more time check and debug this issue, I will fix this on my next update.

    Regards,
    Glen

    Thread Starter shamank

    (@shamank)

    Thank you Glen!

    Have a nice end of week.

    Plugin Author Glen Don Mongaya

    (@glenwpcoder)

    Hello Shamank,

    This issue has been fixed on the newest version.
    Please update the plugin

    Regards,
    Glen

    Thread Starter shamank

    (@shamank)

    That’s great man! Sharing progress bar time among all parallel uploads is a good idea to handle this. It works even if I start an upload and then I click again and I add a file that’s gonna fail.

    However, I can see another bug now. It’s not as important as the other one, but it would be a fine improvement.

    If you start an upload of, let’s say, 5 files of (let’s say) 10 MB, send button gets disabled as expected. So the upload of 50 MB starts. If you cancel all of them, send btn will be still disabled and will wait to those 50 MB files to finish uploading before enabling it back. So the user won’t know what really happened and they won’t be able to send the form until internal uploading process is finished.
    I think you could save the reference of the AJAX connection (in an object scope/global array, since lot of connections may occur at the same time) and abort them in case the user cancels the opperation. I’m not sure if success or fail event will be triggered (I’d assume the fail one), but I think you would be able to handle the abort opperation to perform the right actions after it.

    Thanks man!

    • This reply was modified 5 years, 8 months ago by shamank.
    Plugin Author Glen Don Mongaya

    (@glenwpcoder)

    thanks for checking and reporting this bug.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Little bug when disabling “send” button and uploads success or fails’ is closed to new replies.