• ResolvedPlugin Author Optimizing Matters

    (@optimizingmatters)


    I’ll document confirmed bugs here the next couple of days.

    First one;
    -> problem: images referenced in CSS not translated to correct path, leading to 404’s
    -> fix; open wp-content/autoptimize/classes/autoptimizeStyles.php and on line 6 replace
    const ASSETS_REGEX = '/url\s*\(\s*(?!["\']?data:)(?![\'|\"]?[\#|\%|])([^)]+)\s*\)([^;},]*)/i';
    with
    const ASSETS_REGEX = '/url\s*\(\s*(?!["\']?data:)(?![\'|\"]?[\#|\%|])([^)]+)\s*\)([^;},]*)/iU';
    (so adding capital U to make the regex ungreedy)

Viewing 15 replies - 31 through 45 (of 66 total)
  • Ok, I added the code you gave me to my functions.php.
    I’m still on 2.1.2 version.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    I’m still on 2.1.2 version.

    ah, but the speedupper doesn’t exist there, the code snippet it to be tested with 2.2.1 ??

    Sorry Frank, didn’t understand fully the next step ??

    Till now I put the code directly into my functions:

    View post on imgur.com

    Now I need to update to 2.2.1?

    Thanks ??

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    Now I need to update to 2.2.1?

    yes ??

    Sorry English is not my tongue language, didn’t understand your point.

    Now updated to latest version and style broke.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    Sorry English is not my tongue language

    no problem ??

    Now updated to latest version and style broke.

    OK, in that case can you switch the CSS minifier back to the previous version by opening wp-content/plugins/autoptimize/autoptimize.php and on line 202 change
    @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/yui-php-cssmin-2.4.8-p10/cssmin.php');
    into
    @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/yui-php-cssmin-2.4.8-4_fgo.php');

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    also; make sure to clear any (page) cache you might have to be sure to see the impact of any change we make here ??

    Ok, I changed this code, the style still broke ??

    I always purge nginx and ao cache.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    OK, you can disable/ rollback both + I’ll have a look at your site. your still on 2.2.1 with “inline & defer” active, right?

    Still on 2.2.1 and this option has been checked:
    Inline and Defer CSS

    Now I’m going to roll back to 2.1.2

    Thank you so much Frank for your great support ??

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    when looking at the HTML of your site, I see that all of autoptimize’s code is on non-default places, including the critical CSS (id=”aoatfcss”) and the noscript-block (id=”aonoscrcss”) and that the normal CSS-links are missing. I also see that you at least also have mod_pagespeed active and that you have a whole bunch of inlined CSS (by mod_pagespeed maybe). So I think this is notsomuch a bug in AO, but rather a conflict between AO’s new way of doing inline & defer (using FilamentGroup’s loadCSS) and some other optimization component you’re using @repenter

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    Now I’m going to roll back to 2.1.2

    don’t @repenter, first read what I wrote at https://www.ads-software.com/support/topic/liveblog-known-2-2-issues/page/3/#post-9255711 ??

    Sorry I missed your message. I’m not so pro, but about critical css I know it has been hard coded into my header. About the pagespeed, I use this only for optimizing images. not configured for any css or js optimization.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    I’m not so pro, but about critical css I know it has been hard coded into my header. About the pagespeed, I use this only for optimizing images. not configured for any css or js optimization.

    well, I’m pretty convinced *something* is changing the way the autoptimized CSS is being injected. that *something* seems to be changing the place of the noscript + ao-above-the-fold CSS blocks and removing the linked stylesheets that normally look like this;

    <link rel="preload" as="style" media="all" href="//somesite.net/wp-content/cache/autoptimize/css/autoptimize_3a829863f782ca29a1f91d8dc99d8ccf.css" onload="this.rel='stylesheet'" />

    mark the rel=”preload” and onload attributes specifically which are different from how deferred CSS was loaded before, hence the conflict is only visible now.

    talk to your developers or ask them to contact me, we’ll figure it out ??

    frank

    Anonymous User 14978628

    (@anonymized-14978628)

    Hey, I just noticed this when looking at chrome developer tools > console using latest version of AO:

    JQMIGRATE: Migrate is installed, version 1.4.1
    autoptimize_f69ec39….js:204 Uncaught TypeError: Cannot read property ‘hasClass’ of undefined
    at Object.init (autoptimize_f69ec39….js:204)
    at autoptimize_f69ec39….js:204
    at dispatch (autoptimize_f69ec39….js:4)
    at r.handle (autoptimize_f69ec39….js:4)

Viewing 15 replies - 31 through 45 (of 66 total)
  • The topic ‘“liveblog”; known 2.2 issues’ is closed to new replies.