Loading of every view is wastfull

  • Resolved Drivingralle

    (@drivingralle)


    1 year, 4 months ago

    Hey!

    As I was debugging a clients website I noticed that this plugin is loading it’s tabs/accordion scripts on every view inside the frontend.

    Example: https://play.wekiwi.de/impressum/
    That page doesn’t have tabs or accordion but still the script gets added to the files to be loaded.

    The function in #527 inside the main plugin file also shows no conditions.

    As the plugin is mainly a block the loading of frontend resources could easily be moved to the block itself.

    Would love to see the resources to be loaded just when they are needed. This speeds ups all sites using this plugin.

    Greetings
    derRALF

Viewing 5 replies - 1 through 5 (of 5 total)
  • casper

    (@caspervoogt)

    Thanks for alerting us to this. We’re looking at it and plan to address this in the next release, but yet can’t say when that will be.

    Thread Starter Drivingralle

    (@drivingralle)

    Hey!
    Thanks for the update.

    Looking forward to the next version ??

    casper

    (@caspervoogt)

    We just released 1.1.1, which changes the plugin so it loads the JS only when needed (by default). The plugin has an option (in the admin settings) to force the JS to run on all pages, but that option is disabled by default.

    Thread Starter Drivingralle

    (@drivingralle)

    Hey!
    Thanks for the fast work ??

    Can confirm it working.

    Greetings
    derRALF

    casper

    (@caspervoogt)

    Absolutely! Glad to hear it

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Loading of every view is wastfull’ is closed to new replies.