Lots of errors on activation

@supsystic.com Will confirm they are fixed shortly and close the issue.

Just tried this on 3 different installs. If wp_debug is enabled there is still text generated during activation.

I have tracked the problem to these lines in the frameFPS::init method

register_activation_hook(  PPS_DIR. DS. PPS_MAIN_FILE, array('utilsPps', 'activatePlugin')  ); //See classes/install.php file
register_uninstall_hook(PPS_DIR. DS. PPS_MAIN_FILE, array('utilsPps', 'deletePlugin'));

After some digging I found the issue. You are calling a non static method activatePlugin statically. This leads to a php error which is printed to the browser causing output during activation.

Same for the deletePlugin method.

Changing the function to public static function activatePlugin() fixes the activation issues.

Hello.
Really – thank you for this clarification. We enabled all debug modes – for WordPress and PHP serve – but didn’t saw those warnings, maybe this is depends on PHP version – as method can be static if it is just don’t use any $this. In any case – we will fix this in next release, I think – on next week.

Not a problem.

Just an FYI, when using classes in actions such as activation hooks there are a couple rules.

If it is a static method, call it like you are.

add_action( 'init', array( 'class', 'method' ) );

If it is a non static method it has to be called via an instance of the class like so.

$class = new MyClass;
add_action( 'init', array( $class, 'method' ) );

Or if its being called inside the class itself, say in the __construct or init methods you can do it like this.

add_action( 'init', array( $this, 'method' ) );

The catch though with calling it from instance based classes ( the second 2 above ) is that if it ever needs to be unhooked you have to pass in the same instance and not a new one.

For example

This will work.

$class = new MyClass;
add_action( 'init', array( $class, 'method' ) );
remove_action( 'init', array( $class, 'method' ) );

This won’t.

$class = new MyClass;
add_action( 'init', array( $class, 'method' ) );

$new_instance = new MyClass;
remove_action( 'init', array( $new_instance , 'method' ) );

So in the example above you may want to store the $class variable as a global, allowing you to later use it again like so.

global $class;
remove_action( 'init', array( $class, 'method' ) );

Hope this helps in the future.

Also try adding this to your wp-config.php file for your development site. It will guarantee you find all the bugs ( not usability bugs, just errors ) before releasing.

define('WP_DEBUG', true);
if (WP_DEBUG) {
	define('WP_DEBUG_LOG', true);
	define('WP_DEBUG_DISPLAY', true);
	@ini_set('display_errors', 0);
}

Hello.
Thank you for clarifications about callbacks for WordPress events calling, now it is more clear for us. But in last example:
@ini_set(‘display_errors’, 0);
Maybe it should be @ini_set(‘display_errors’, 1); ?

@supsystic.com Valid point. I think setting it to 0 is done because WP has built in PHP error handling meaning setting it to 1 would show errors twice, but test it and let me know.

I generally run all development with those lines and Debug Bar plugin and usually can find all errors during development and before release.

PS glad to help.