"membership has ended" repeated messages

Hey anitrawolf,

I believe this is a bug related to one of the previous versions, so this should already be fixed in the latest version of the plugin.

This is from the 4.0.0.6 change log

Fix a bug that created duplicate email templates every time an email was sent

Best regards,
Bojan

Hey again anitrawolf,

A quick update on the issue, we’ve released a new version that should fix the problem with Additional Automated Messages add on causing fatal error on Automated Email Responses page in the Setting.

Best regards,
Bojan

Bojan,

Thank you, I have updated to the latest version and am doing some testing.

Question- I just did a renewal on a 5 day membership and on the account page it reads:
Membership Name – Status – Expire Date, then it gives my membership type, says “expired” – expire date is Nov. 1, 2015. So my next question is: why is it saying it’s expired if it’s just been renewed and doesn’t expire until Nov. 1?

I’ll let you know if I run across any more bugs in testing.

Anitra

Hey Anitra,

Can you please add more information so we can try to recreate this? Did you renew it from the admin, or you renew it as a user from the front end.

If as a user, can you check billing to see if the payment actually went through? Can that user see protected pages for that level? Which payment gateway are you using?

I’ll let you know if I run across any more bugs in testing.

Please do, this helps us a lot ??

Best regards,
Bojan

Thanks for your reply. Here is the info you requested:
– I renewed as a user from the front end.
– The payment was through Paypal and yes, it did go through.
– I checked the “account” page again today and the status has changed from “expired” to “active” – perhaps it just takes some time for the system to register payment… but it seems odd that it registers the new expiration date right away but not the status.

Hey anitrawolf,

Glad that it worked out in the end.

Status changes once the payment is made, it’s possible that there was some delay from PayPal or something similar that caused this.

Billing section has transaction logs where you can check for additional information related to the payments, see screenshot https://screencast.com/t/LVdF9GEnlvzc.

Please let us know if you run into any other issues ??

Cheers,
Bojan

Bojan,

So… I’m continuing to test the plugin. I upgraded to the latest version and did another 5 day membership test. The membership expired yesterday. And rather than receiving 9 “your membership has expired” messages – I got NONE. I really need one message to go through, so my members know they need to renew. How do I accomplish this? Thanks!

Hey again,

I completely agree on that one, this is exactly why the email settings are there for ??

Can you please post screenshot of the Automated Email Responses related to this settings and also membership type of that membership that you’re using as well.

Looking forward for your response ??

Cheers,
Bojan

Bojan,

Update – After messaging you, I realized that I had placed some code in my config file that was suggested in a prior topic in order to stop the repeat messages. The code below in my config file as suggested by this topic: https://www.ads-software.com/support/topic/your-_-membership-has-ended-repeated-messages?replies=8:

define( "MS_DUPLICATE_EMAIL_HOURS", 24 );

I removed that line yesterday and tested again. So far today (the expiration date for the membership I’m testing), I’ve received two “your membership has expired” messages… so apparently the same problem still exists – duplicate emails are still begin sent, unless there is code that says to send only one message every 24 hours, then none are sent… strange.

Here is a link to the screenshot you requested. https://oaiowa.org/wp-content/uploads/2015/11/Screen-Shot-2015-11-03-at-9.20.44-AM.png The membership type is a 5 day standard membership –

Quick update – I ended up receiving 4 “your membership has ended” messages – about one every 6 hours on the day after the membership expired. After that, it seems the messages have stopped (I have not received any in the past 36 hours.) Hope that helps with troubleshooting.

Thanks!!

Hey anitrawolf,

That’s pretty odd. I’ve been testing this on my end with 1 day membership that’s why it took slightly longer for me to respond.

I can’t recreate the issue, I’m getting only one email https://screencast.com/t/iPhbbbJeNu, https://screencast.com/t/LY6THEzSJCy.

Do you have any other custom parts added in wp-config.php? If I recall correctly you did roll back to older versions because of the bugs you’ve been encountering.

Can you try with the fresh plugin files? Also try to create new user for new membership so we can possibly check if this is somehow affecting already created users/levels.

I’d suggest creating site backup just in case something goes wrong ??

Cheers,
Bojan

Bojian,

Thank you for your suggestions. I will give these a try in the next few days and report back my discoveries. Thanks!

Please let me know how that goes ??

Cheers,
Bojan

Bojan,

Here is how my testing went over the weekend. I assured there were no other things in my config file and that the plugin files are the latest version 4.0.0.7.

I did 4 tests:
(1) I did a renewal of an existing member with an existing membership – 4 repeat “your membership has ended” messages.
(2) I created a new user with an existing membership – 4 repeat “your membership has ended” messages.
(3) I created a new membership type. When an existing user’s old membership expired, I renewed using the new membership type. 2 repeat messages (so far), we are only 1/2 way into the expiration day.
(4) I created a new user and subscribed them to this new membership type – again 2 repeat messages.

A couple more notes that may be helpful:
(1) I have the time zone set to Chicago. Renewal messages start arriving around 10 p.m. the evening BEFORE the expiration date. I’ve no idea if it’s relevant or not, but is there a chance since the times aren’t syncing that the bug is in there somewhere? Also related to this – when the expiration emails start going out, the membership isn’t officially expired yet.
(2) I am integrating with Buddypress. I don’t have any automated messages associated with Buddypress, but you never know what plugin conflicts might cause issues.

Let me know what else to troubleshoot and I’ll get to work on it. I want to get to the bottom of this soon!

Thanks!!

Hey again anitrawolf,

After additional testing and code review it appears that this is a bug. I’m not sure why neither myself nor our developer managed to recreate this.

What we found out is that the email is not sent when the subscription EXPIRES but when it is DEACTIVATED. The automatic status check runs every 6 hours so the email is sent every 6 hours.

To fix this please go to file membership/app/controller/class-ms-controller-communication.php

and swap lines 199 and 230 so it looks like this:

...
199:        case MS_Model_Event::TYPE_MS_EXPIRED:   // before DEACTIVATED
                $enqueue[] = MS_Model_Communication::COMM_TYPE_FINISHED;
                break;
...
230:        case MS_Model_Event::TYPE_MS_DEACTIVATED:  // before EXPIRED
                break;
...

Please let me know if this helps ??

Cheers,
Bojan