Menu label issue in WP3.3 upgrade

Also appears that some users using page menu editor plugin has had similar problems since 3.3 upgrade.

That’s incorrect. I fixed the Page Menu Editor plugin a month ago when 3.3 beta 2 highlighted the issue with my plugin.

Thanks for the really quick update. Made a donation on your PayPal to say thank you.

The update code was just copy & pasted from the original author’s plugin.

It’s a shame that it’s still without proper GPL attribution too, credit should be given where it’s due.

I’m still running WP 3.2.1 and it seems that the upgrade to AIOSEO 1.6.13.8 has broken the Menu Label functionality on my site. Is it possible that in fixing the issue for WP 3.3 it no longer works in earlier versions?
I’m going to try rolling back to an earlier version of AIOSEO. I don’t want to update to WP3.3 until most/all of the plugins are compatible.

Is it possible that in fixing the issue for WP 3.3 it no longer works in earlier versions?

My code certainly doesn’t and the AIOSP code essentially duplicates that with the exception of post meta keys. There is version checks in place to ensure that the new change doesn’t affect older sites as I released the update about a month ago or so.

However, there have been a number of other updates to my plugin over the course of the year which have also been copied. Probably one of those, although I’ve not had any complaints off direct users, so maybe something’s been altered to cause the issue.

hurricane,
Attribution is given.

Brimfulof,
It should be working, but I’m looking into that now.

Thanks for the quick response (and an excellent plugin). I’ve just reverted to Version 1.6.13.4 and Menu Labels are working again.
I’m trying to figure out if it’s a conflict with one of my other plugins or theme.
Theme: Arclite
Plugins: 30, but possible conflicts could be with WP Super Cache and Page Links Manager.
Will report back if I get anywhere.

Brimfulof,

Install https://www.ads-software.com/extend/plugins/wordpress-debug/ and send the debug information to
aio [AT] semperfiwebdesign DOTCOM

Also try clearing your cache.

Brimfulof,

Can you email me directly with your WordPress login info? I’d like to take a look. I’m not able to recreate this issue on older versions of WordPress.

@ Michael Torbert

You may need to advise Automatic and the Free Software Foundation that you think a comment hidden within a PHP file supercedes the terms of the GPL licence and that you don’t have to do more when using other people’s work.

I’d recommend reading the GPL which you’re bound by as you’ve been in breach of it for 2 or 3 years.

I’d be curious to see where in the GPL it mentions attribution outside of the source code is indeed required.

There’s no mention of it in v2
https://www.gnu.org/licenses/old-licenses/gpl-2.0.html

And it’s optional in v3:
https://www.gnu.org/licenses/gpl.html

Here’s a nice post:
https://madebyraygun.com/blog/2011/attribution-and-the-gpl/

hurricane,

Actually, requiring attribution is the reason why the original BSD license was incompatible with the GPL (v2) in the first place; that having been said, all the code is there, it’s publicly available, and there’s attribution provided on top of that. I’d argue that it’s actually clearer to have a comment right there where the code is being used, as well.

I’m afraid I’m going to have to side with Andrea on this one. There is no attribution requirement for GPL software. As long as the licenses are compatible GPL2/GPL3/etc then you’re literally free to copy and paste and do whatever you want without attribution.

It is common courtesy to attribute someone else’s code, a quick comment like the one that’s included is more than enough to let others know where that code came from.

Perhaps you should read the GPL… I think you’re misunderstanding a few things.

Seeing as the subject has been brought up, copied from the GPL linked to by Andrea_r, I believe hurricane is referring to

You may copy and distribute verbatim copies of the Program’s source code as you receive it, in any medium, provided that you conspicuously and appropriately publish on each copy an appropriate copyright notice and disclaimer of warranty;

Conspiciously means noticeable. I don’t think a comment hidden in the code is noticeable to about 95%+ of the users of the plugin? But that aside, there’s no actual disclaimer of warranty in there either. I’ve always had one on my website’s plugins section and more recently added it directly into the plugin, but as per WordPress’s own plugin restrictions page, it comes under GPL v2 if there is no license present.

You must cause the modified files to carry prominent notices stating that you changed the files and the date of any change.

I don’t believe that’s there?

I’m still running WP 3.2.1 and it seems that the upgrade to AIOSEO 1.6.13.8 has broken the Menu Label functionality on my site

This is because a vital part of the code has been removed during the copy and as your theme uses span tags in the menu it’s breaking it.

It’s not a verbatim copy tho, it’s modified and partial. That’s all.