menu not dropping down if it contains links

I can see the top menu on that site, and the dropdown works (you have to click on it, I think you selected the dropdown on click, right?): https://i59.tinypic.com/2hro9zn.png
Btw remove that “-” in the link of the “What all I do” menu item, and replace it with “#” or nothing.

1) https://themesandco.com/snippet/linking-the-whole-slides-picture-to-a-pagepost-in-customizr/
2) Appearance -> Customize -> Content: home, posts.. -> Post Metas (category…)
uncheck
Display posts metas for single posts

Thanks.. had added the “-” in menu because WP wasnt letting me add it as an item till I put something in the URL

Yep, I know, but “#” is a better choice ??
After you created the menu item you can also remove that “#”.
Glad you solved ??

actually i wanted the button text to link to a hyperlink..not the whole slide image (as mentioned in the code snippet) .. how do i do that?

Well:

1. How do I link a slider image to a link and not a page?

slider image ( and not slider button ) is misleading..
But, always in that site you can search and find a lot of useful snippet, such as this:
https://themesandco.com/snippet/setting-a-custom-external-url-to-a-slide/
(clearly read also the preface)
The second snippet proposed in that page does what you want:
Replacing the call to action link by a custom external url
A slightly modified version, allows you, in a simple way, to open the link in a new window:

add_filter('tc_slide_link_url' , 'my_slide_custom_link', 10, 2);
function my_slide_custom_link( $slide_link , $image_id ) {
    //does nothing if the image's id is not the targeted one
    if ( MY-IMAGE-ID != $image_id )
        return $slide_link;
    //sets a custom url for the targeted slide
    return 'MY-CUSTOM-URL';
    // or use the following if you want to open it in a new window
    // return 'MY-CUSTOM-URL" target="_blank';
}

hope this helps ??

thanks