Migration to 2.0 raises warning regarding an invalid database schema

  • Resolved warrenseine

    (@warrenseine)


    9 years, 2 months ago

    Hi,

    The plugin was updated two weeks ago from 1.1.20 to 2.0. One of the breaking changes is that the PluginVersion option moved from wp_option to wp_sitemeta. The migration code is run at the initialization of the plugin. It first checks for PluginVersion and if unset, it runs the whole migration process, which first creates the wp_gdbc_attempts table, then renames it to wp_gdbc_attempts_old, then tries to move the (non-existing) data from wp_gdbc_attempts_old to wp_gdbc_attempts. Columns in wp_gdbc_attempts_old are expected to be in the old format which cause the migration code to fail, raising the following warning:

    WordPress database error Unknown column 'IsIpBlocked' in 'where clause' for query SELECT DISTINCT ClientIp FROM wp_gdbc_attempts_old WHERE IsIpBlocked <> 0 AND IsDeleted = 0 made by include('phar:///usr/local/bin/wp/php/boot-phar.php'), include('phar:///usr/local/bin/wp/php/wp-cli.php'), WP_CLI\Runner->start, WP_CLI\Runner->load_wordpress, require('phar:///usr/local/bin/wp/php/wp-settings-cli.php'), do_action('plugins_loaded'), call_user_func_array, GoodByeCaptcha::getInstance, GoodByeCaptcha->__construct, GdbcUpdatesController::updateToCurrentVersion, GdbcUpdatesController::migrateTableDataFromV1
    WordPress database error Unknown column 'CountryId' in 'field list' for query
    SELECT Id, UNIX_TIMESTAMP(CreatedDate) AS CreatedDate, ModuleId, SectionId, ClientIp, CountryId, ReasonId
    FROM wp_gdbc_attempts_old WHERE IsDeleted = 0 AND CreatedDate BETWEEN '2015-11-17 16:09:35' AND '2015-12-17 16:09:35' order by CreatedDate DESC LIMIT 500;
    made by include('phar:///usr/local/bin/wp/php/boot-phar.php'), include('phar:///usr/local/bin/wp/php/wp-cli.php'), WP_CLI\Runner->start, WP_CLI\Runner->load_wordpress, require('phar:///usr/local/bin/wp/php/wp-settings-cli.php'), do_action('plugins_loaded'), call_user_func_array, GoodByeCaptcha::getInstance, GoodByeCaptcha->__construct, GdbcUpdatesController::updateToCurrentVersion, GdbcUpdatesController::migrateTableDataFromV1

    I think the problem is that the migration code should create the wp_gdbc_attempts after it renames the pre-existing table. All of this is in engine/GdbcUpdatesController.php.

    https://www.ads-software.com/plugins/goodbye-captcha/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter warrenseine

    (@warrenseine)

    I should note that:
    – I’m running in a multisite environment
    – Goodbye Captcha is installed network-wide
    – I’m doing a fresh install of Goodbye Captcha with wp-cli
    – I load a dump of wp_options after installing WordPress
    – The warning appears once then PluginVersion is correctly set

    My fix is simple. In engine/GdbcUpdatesController.php, change line 76:
    if( -1 === version_compare($savedPluginVersion, '2.0')
    to:
    if( -1 === version_compare($savedPluginVersion, '2.0') && $savedPluginVersion !== null)

    Plugin Author MihChe

    (@mihche)

    Hi warrenseine,
    Great catch! Thanks for reporting it!
    I’ll have a look at it and I’ll fix this!

    Happy New Year!
    Mihai

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Migration to 2.0 raises warning regarding an invalid database schema’ is closed to new replies.

Tags